We need to have EnumSettingsOption be able to handle the illustration components we just introduced
Depends on D12643
Details
Details
Summary
Test Plan
Confirmed that there were no regressions + everything works as expected
Normal icon:
Illustration:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 3 2024, 1:02 AM2024-07-03 01:02:01 (UTC-7)
ginsu edited the summary of this revision. (Show Details)Jul 3 2024, 1:04 AM2024-07-03 01:04:32 (UTC-7)
ginsu added a parent revision: D12644: [native] introduce new vector assets for new thread notification settings experience.
Harbormaster completed remote builds in B30074: Diff 41928.Jul 3 2024, 1:18 AM2024-07-03 01:18:34 (UTC-7)
This revision is now accepted and ready to land.Jul 3 2024, 2:26 AM2024-07-03 02:26:12 (UTC-7)
ginsu added a child revision: D12653: [native] introduce disabled prop for EnumSettingsOption.Jul 3 2024, 5:35 PM2024-07-03 17:35:52 (UTC-7)
ginsu added a parent revision: D12642: [native] introduce nav logic for ThreadSettingsNotifications.
ginsu edited the summary of this revision. (Show Details)Jul 3 2024, 5:38 PM2024-07-03 17:38:53 (UTC-7)
ginsu added a parent revision: D12643: [native] introduce type prop to EnumSettingsOption component.
ginsu removed a parent revision: D12642: [native] introduce nav logic for ThreadSettingsNotifications.
Harbormaster completed remote builds in B30155: Diff 42046.Jul 4 2024, 11:04 AM2024-07-04 11:04:40 (UTC-7)
Closed by commit rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration… (authored by ginsu). · Explain WhyJul 4 2024, 11:21 AM2024-07-04 11:21:13 (UTC-7)
This revision was automatically updated to reflect the committed changes.