Page MenuHomePhabricator
Differential D12663

[native] update thread notif settings ui to handle case when parent thread is in background
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 10:42 PM.
Tags
None
Referenced Files
F2210093: D12663.diff
Sun, Jul 7, 8:36 PM
Unknown Object (File)
Wed, Jul 3, 11:17 PM
Unknown Object (File)
Wed, Jul 3, 11:17 PM
Unknown Object (File)
Wed, Jul 3, 11:14 PM
F2185067: Screenshot 2024-07-04 at 1.49.47 AM.png
Wed, Jul 3, 10:49 PM
F2185065: Screenshot 2024-07-04 at 1.49.19 AM.png
Wed, Jul 3, 10:49 PM
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMe60d77284b98: [native] update thread notif settings ui to handle case when parent thread is…
Summary

If a thread's parent is in in the background, then instead of showing our usual interface we show a prompt to the user telling them that they can't update the notification settings. We also don't render the save button

Screenshot 2024-07-04 at 1.49.19 AM.png (2×3 px, 880 KB)

Depends on D12662

Test Plan

Please see the screenshot below

Screenshot 2024-07-04 at 1.49.47 AM.png (1×1 px, 793 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Jul 3, 10:42 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 10:42 PM
ginsu added a child revision: D12664: [lib/native/web] update copy BADGE_COUNT => NOTIF_COUNT.Wed, Jul 3, 10:48 PM
ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
Harbormaster completed remote builds in B30127: Diff 41998.Wed, Jul 3, 10:59 PM
ginsu requested review of this revision.Wed, Jul 3, 10:59 PM
ginsu edited the summary of this revision. (Show Details)Thu, Jul 4, 12:24 AM
ginsu added a parent revision: D12662: [native] introduce thread notif settings notice text.
ashoat accepted this revision.Thu, Jul 4, 6:33 AM
This revision is now accepted and ready to land.Thu, Jul 4, 6:33 AM
ginsu updated this revision to Diff 42055.Thu, Jul 4, 11:04 AM

rebase before landing

This revision was landed with ongoing or failed builds.Thu, Jul 4, 11:21 AM
Closed by commit rCOMMe60d77284b98: [native] update thread notif settings ui to handle case when parent thread is… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe60d77284b98: [native] update thread notif settings ui to handle case when parent thread is….
Harbormaster completed remote builds in B30163: Diff 42055.Thu, Jul 4, 11:45 AM

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
132 lines

Diff 42076

View Options

native/chat/settings/thread-settings-notifications.react.js

Loading...