Page MenuHomePhabricator

[native] update thread notif settings ui to handle case when parent thread is in background
ClosedPublic

Authored by ginsu on Jul 3 2024, 10:42 PM.
Tags
None
Referenced Files
F2903482: D12663.diff
Sat, Oct 5, 10:37 PM
Unknown Object (File)
Wed, Sep 25, 8:51 PM
Unknown Object (File)
Wed, Sep 25, 8:50 PM
Unknown Object (File)
Mon, Sep 9, 7:14 AM
Unknown Object (File)
Fri, Sep 6, 9:15 AM
Unknown Object (File)
Sep 5 2024, 6:41 PM
Unknown Object (File)
Sep 5 2024, 6:40 PM
Unknown Object (File)
Sep 5 2024, 6:39 PM
Subscribers

Details

Summary

If a thread's parent is in in the background, then instead of showing our usual interface we show a prompt to the user telling them that they can't update the notification settings. We also don't render the save button

Screenshot 2024-07-04 at 1.49.19 AM.png (2×3 px, 880 KB)

Depends on D12662

Test Plan

Please see the screenshot below

Screenshot 2024-07-04 at 1.49.47 AM.png (1×1 px, 793 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the summary of this revision. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu requested review of this revision.Jul 3 2024, 10:59 PM
This revision is now accepted and ready to land.Jul 4 2024, 6:33 AM
This revision was landed with ongoing or failed builds.Jul 4 2024, 11:21 AM
This revision was automatically updated to reflect the committed changes.