Page MenuHomePhabricator
Differential D12645

[native] extend icon prop in EnumSettingsOption to handle illustration components
ClosedPublic
Actions

Authored by ginsu on Wed, Jul 3, 1:02 AM.
Tags
None
Referenced Files
F2233941: D12645.id42068.diff
Wed, Jul 10, 8:48 PM
F2233513: D12645.id42047.diff
Wed, Jul 10, 7:26 PM
F2233002: D12645.id41928.diff
Wed, Jul 10, 6:02 PM
Unknown Object (File)
Mon, Jul 8, 11:29 AM
Unknown Object (File)
Sun, Jul 7, 4:41 AM
Unknown Object (File)
Wed, Jul 3, 11:53 AM
Unknown Object (File)
Wed, Jul 3, 11:53 AM
Unknown Object (File)
Wed, Jul 3, 11:53 AM
View All 10 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration…
Summary

We need to have EnumSettingsOption be able to handle the illustration components we just introduced

Depends on D12643

Test Plan

Confirmed that there were no regressions + everything works as expected

Normal icon:

Screenshot 2024-07-03 at 4.03.50 AM.png (1×1 px, 738 KB)

Illustration:

Screenshot 2024-07-02 at 9.46.36 PM.png (1×1 px, 760 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Wed, Jul 3, 1:02 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Jul 3, 1:02 AM
ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 1:04 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12644: [native] introduce new vector assets for new thread notification settings experience.
ginsu attached a referenced file: F2174686: Screenshot 2024-07-02 at 9.46.36 PM.png. (Show Details)
ginsu attached a referenced file: F2174684: Screenshot 2024-07-03 at 4.03.50 AM.png. (Show Details)
ginsu added a child revision: D12646: [lib/web] introduce useThreadSettingsNotifications.Wed, Jul 3, 1:07 AM
Harbormaster completed remote builds in B30074: Diff 41928.Wed, Jul 3, 1:18 AM
ginsu requested review of this revision.Wed, Jul 3, 1:18 AM
inka accepted this revision.Wed, Jul 3, 2:26 AM
This revision is now accepted and ready to land.Wed, Jul 3, 2:26 AM
ginsu removed a parent revision: D12644: [native] introduce new vector assets for new thread notification settings experience.Wed, Jul 3, 3:04 PM
ginsu removed a child revision: D12646: [lib/web] introduce useThreadSettingsNotifications.
ginsu added a child revision: D12653: [native] introduce disabled prop for EnumSettingsOption.Wed, Jul 3, 5:35 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D12642: [native] introduce nav logic for ThreadSettingsNotifications.
ginsu edited the summary of this revision. (Show Details)Wed, Jul 3, 5:38 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D12643: [native] introduce type prop to EnumSettingsOption component.
ginsu removed a parent revision: D12642: [native] introduce nav logic for ThreadSettingsNotifications.
ginsu updated this revision to Diff 42046.Thu, Jul 4, 10:48 AM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

Harbormaster completed remote builds in B30155: Diff 42046.Thu, Jul 4, 11:04 AM
Closed by commit rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration… (authored by ginsu). · Explain WhyThu, Jul 4, 11:21 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM5795c5998829: [native] extend icon prop in EnumSettingsOption to handle illustration….

Revision Contents
Changeset List

PathSize
native/
components/
16 lines

Diff 42068

View Options

native/components/enum-settings-option.react.js

Loading...