Page MenuHomePhabricator
Differential D12642

[native] introduce nav logic for ThreadSettingsNotifications
ClosedPublic
Actions

Authored by ginsu on Jul 2 2024, 6:06 PM.
Tags
None
Referenced Files
F3574644: D12642.diff
Sat, Dec 28, 5:53 PM
Unknown Object (File)
Sun, Dec 22, 5:00 PM
Unknown Object (File)
Wed, Dec 18, 1:43 AM
Unknown Object (File)
Sun, Dec 8, 10:50 PM
Unknown Object (File)
Sun, Dec 8, 9:15 AM
Unknown Object (File)
Fri, Dec 6, 2:14 PM
Unknown Object (File)
Wed, Dec 4, 9:11 PM
Unknown Object (File)
Nov 11 2024, 5:31 AM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications
Summary

For the new thread notif settings we decided that we want this user experience to have it's own page. This diff introduces the nave logic needed for this

Linear task: https://linear.app/comm/issue/ENG-7776/improve-thread-notifications-settings-user-experience

Test Plan

Confirmed that I can navigate to this screen

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 2 2024, 6:06 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 2 2024, 6:06 PM
ginsu updated this revision to Diff 41918.Jul 2 2024, 6:10 PM

update

ginsu added inline comments.Jul 2 2024, 6:12 PM
native/chat/chat.react.js
335–337 ↗(On Diff #41918)

Confirmed this is the same behavior with web

nonsidebar:

Screenshot 2024-07-02 at 9.07.21 PM.png (2×3 px, 1 MB)

sidebar:

Screenshot 2024-07-02 at 9.07.31 PM.png (2×3 px, 950 KB)

ginsu attached a referenced file: F2171721: Screenshot 2024-07-02 at 9.07.31 PM.png. (Show Details)Jul 2 2024, 6:12 PM
ginsu attached a referenced file: F2171719: Screenshot 2024-07-02 at 9.07.21 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: ashoat, inka.
Harbormaster failed remote builds in B30066: Diff 41917!Jul 2 2024, 6:19 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2024, 6:22 PM
Harbormaster failed remote builds in B30067: Diff 41918!
ginsu updated this revision to Diff 41920.Jul 2 2024, 6:36 PM

update

ginsu added inline comments.Jul 2 2024, 6:37 PM
native/chat/chat.react.js
335–337

Confirmed this is the same behavior with web

nonsidebar:

Screenshot 2024-07-02 at 9.07.21 PM.png (2×3 px, 1 MB)

sidebar:

Screenshot 2024-07-02 at 9.07.31 PM.png (2×3 px, 950 KB)

ginsu attached a referenced file: F2171946: Screenshot 2024-07-02 at 9.07.31 PM.png. (Show Details)Jul 2 2024, 6:37 PM
ginsu attached a referenced file: F2171943: Screenshot 2024-07-02 at 9.07.21 PM.png. (Show Details)
ginsu added a child revision: D12643: [native] introduce type prop to EnumSettingsOption component.Jul 2 2024, 6:41 PM
Harbormaster completed remote builds in B30069: Diff 41920.Jul 2 2024, 6:52 PM
ginsu requested review of this revision.Jul 2 2024, 6:52 PM
ashoat accepted this revision.Jul 2 2024, 7:14 PM
This revision is now accepted and ready to land.Jul 2 2024, 7:14 PM
ginsu added a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.Jul 3 2024, 5:37 PM
ginsu removed a child revision: D12645: [native] extend icon prop in EnumSettingsOption to handle illustration components.
ginsu updated this revision to Diff 42044.Jul 4 2024, 10:47 AM

rebase before landing

Harbormaster completed remote builds in B30153: Diff 42044.Jul 4 2024, 11:03 AM
Closed by commit rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications (authored by ginsu). · Explain WhyJul 4 2024, 11:21 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM4df530f032dc: [native] introduce nav logic for ThreadSettingsNotifications.

Revision Contents
Changeset List

PathSize
native/
chat/
20 lines
settings/
39 lines
navigation/
5 lines

Diff 41920

View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/settings/thread-settings-notifications.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...