Page MenuHomePhabricator

[lib] Fix crash when pressing message from anonymous author
ClosedPublic

Authored by ashoat on Jul 6 2024, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:03 PM
Unknown Object (File)
Sun, Sep 8, 3:02 PM
Unknown Object (File)
Sun, Sep 8, 3:02 PM
Unknown Object (File)
Sun, Sep 1, 4:26 AM
Unknown Object (File)
Wed, Aug 28, 5:00 AM
Unknown Object (File)
Mon, Aug 26, 6:37 PM
Unknown Object (File)
Mon, Aug 26, 12:35 PM
Subscribers
None

Details

Summary

If we don't have a username for a message author, the app currently crashing when you press the message.

It looks like the Flow types here are unnecessarily strict. Once I relaxed them, I was able to remove the invariant.

This resolves ENG-8777.

Depends on D12679

Test Plan

I reverted D12674 to reproduce the issue. I then created a new user from a separate account, and sent a message to my main user. The main user was able to press the message, react, and start a sidebar on the messages for the other user, even though the other user showed up as "anonymous"

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage