Page MenuHomePhabricator
Differential D12784

Make client notif generation code operate on thick threads only
ClosedPublic
Actions

Authored by marcin on Jul 17 2024, 6:04 AM.
Tags
None
Referenced Files
F4435577: D12784.diff
Thu, Feb 27, 4:11 PM
Unknown Object (File)
Wed, Feb 26, 9:12 AM
Unknown Object (File)
Tue, Feb 18, 8:05 AM
Unknown Object (File)
Jan 19 2025, 6:28 PM
Unknown Object (File)
Jan 19 2025, 6:28 PM
Unknown Object (File)
Jan 19 2025, 6:28 PM
Unknown Object (File)
Jan 19 2025, 6:28 PM
Unknown Object (File)
Jan 19 2025, 6:28 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only
Summary

This differential narrows the scope of on-the-client notif generation code to operate on thick threads only.

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-8809
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jul 17 2024, 6:04 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 17 2024, 6:04 AM
Harbormaster completed remote builds in B30411: Diff 42382.Jul 17 2024, 6:21 AM
marcin requested review of this revision.Jul 17 2024, 6:21 AM
ashoat accepted this revision.Jul 17 2024, 6:22 AM
This revision is now accepted and ready to land.Jul 17 2024, 6:22 AM
marcin updated this revision to Diff 42396.Jul 17 2024, 10:33 AM

Rebase before landing

Harbormaster completed remote builds in B30424: Diff 42396.Jul 17 2024, 10:50 AM
marcin updated this revision to Diff 42399.Jul 17 2024, 10:57 AM

Rebase before landing

Harbormaster failed remote builds in B30426: Diff 42399!Jul 17 2024, 11:01 AM
marcin updated this revision to Diff 42454.Jul 18 2024, 1:39 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Jul 18 2024, 1:41 AM
Closed by commit rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMd8e292b74d30: Make client notif generation code operate on thick threads only.
Harbormaster completed remote builds in B30456: Diff 42454.Jul 18 2024, 1:56 AM
ashoat mentioned this in D12722: [lib] Add `invariant` to suppress `flow` issue in `getPushUserInfo`.Jul 18 2024, 10:17 AM

Revision Contents
Changeset List

PathSize
lib/
push/
7 lines
23 lines
selectors/
20 lines
types/
4 lines

Diff 42396

View Options

lib/push/send-hooks.react.js

Loading...
View Options

lib/push/send-utils.js

Loading...
View Options

lib/selectors/thread-selectors.js

Loading...
View Options

lib/types/thread-types.js

Loading...