Page MenuHomePhabricator
Differential D12771

[Tunnelbroker] implement sending FCM notifs by client
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 1:53 AM.
Tags
None
Referenced Files
F3380829: D12771.id42532.diff
Thu, Nov 28, 2:36 AM
F3380730: D12771.id42328.diff
Thu, Nov 28, 1:47 AM
Unknown Object (File)
Mon, Nov 18, 10:56 AM
Unknown Object (File)
Mon, Nov 18, 7:48 AM
Unknown Object (File)
Mon, Nov 18, 7:30 AM
Unknown Object (File)
Mon, Nov 18, 7:16 AM
Unknown Object (File)
Mon, Nov 18, 4:22 AM
Unknown Object (File)
Mon, Nov 18, 1:57 AM
View All 51 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM781cf567e424: [Tunnelbroker] implement sending FCM notifs by client
Summary

Handle FCMNotif message from device.

Depends on D12770

Test Plan

Tested in D12772.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2024, 1:53 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 1:53 AM
kamil added a child revision: D12772: [lib] implement sending FCM notifs using Tunnelbroker.Jul 16 2024, 1:54 AM
kamil added a child revision: D12773: [Tunnelbroker] simplify retrieving device token.
Harbormaster completed remote builds in B30366: Diff 42328.Jul 16 2024, 2:09 AM
kamil published this revision for review.Jul 16 2024, 2:46 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
services/tunnelbroker/src/websockets/session.rs
430–447 ↗(On Diff #42328)

code duplication, handled in D12773

bartek accepted this revision.Jul 18 2024, 7:21 AM
This revision is now accepted and ready to land.Jul 18 2024, 7:21 AM
Closed by commit rCOMM781cf567e424: [Tunnelbroker] implement sending FCM notifs by client (authored by kamil). · Explain WhyJul 19 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM781cf567e424: [Tunnelbroker] implement sending FCM notifs by client.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
1 line
notifs/
apns/
3 lines
fcm/
2 lines
websockets/
62 lines

Diff 42532

View Options

services/tunnelbroker/src/main.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...
View Options

services/tunnelbroker/src/notifs/fcm/mod.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...