Differential D12832

[identity] modify get_all_user_details to return wallet addresses too
ClosedPublic
Actions

Authored by varun on Jul 21 2024, 8:46 PM.

Tags

None

Referenced Files

	F3375227: D12832.id42599.diff
	Tue, Nov 26, 7:00 PM

	F3374555: D12832.diff
	Tue, Nov 26, 4:05 PM

	Unknown Object (File)
	Sat, Nov 23, 2:45 AM

	Unknown Object (File)
	Fri, Nov 1, 10:45 AM

	Unknown Object (File)
	Fri, Nov 1, 10:45 AM

	Unknown Object (File)
	Fri, Nov 1, 10:45 AM

	Unknown Object (File)
	Fri, Nov 1, 10:44 AM

	Unknown Object (File)
	Oct 18 2024, 3:20 AM

View All 38 Files

Subscribers

Details

Reviewers

will
bartek

Commits

rCOMM2f4606fcdba3: [identity] modify get_all_user_details to return wallet addresses too

Summary

this bug was kind of hidden because we were re-writing claimed wallet addresses to the reserved usernames table, so the identity search index was still being populated with all the addresses -- just from the wrong source. after D12831, we're no longer re-writing claimed wallet addresses to the reserved usernames table, so the identity search index will not contain claimed/registered wallet addresses. by modifying get_all_user_details to return wallet addresses, we resolve this issue.

Depends on D12831

Test Plan

called get_all_user_details from main and confirmed that it now contains UserDetails with wallet addresses

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jul 21 2024, 8:46 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 21 2024, 8:46 PM

varun published this revision for review.Jul 21 2024, 8:54 PM

varun added inline comments.

services/identity/src/database.rs
991 ↗	(On Diff #42599)	I’ll change this line to avoid leaking sensitive data

Harbormaster completed remote builds in B30552: Diff 42599.Jul 21 2024, 9:11 PM

bartek accepted this revision.Jul 22 2024, 1:58 AM

This revision is now accepted and ready to land.Jul 22 2024, 1:58 AM

Closed by commit rCOMM2f4606fcdba3: [identity] modify get_all_user_details to return wallet addresses too (authored by varun). · Explain WhyJul 22 2024, 10:03 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM2f4606fcdba3: [identity] modify get_all_user_details to return wallet addresses too.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

41 lines

database/

2 lines

Diff 42633

services/identity/src/database.rs

Loading...

services/identity/src/database/device_list.rs

Loading...