Differential D12863

[terraform] move image config to aws_ecs and add custom image variable
ClosedPublic
Actions

Authored by will on Jul 23 2024, 11:29 AM.

Tags

None

Referenced Files

	F3349846: D12863.id42720.diff
	Fri, Nov 22, 7:30 PM

	F3349700: D12863.id42747.diff
	Fri, Nov 22, 6:42 PM

	Unknown Object (File)
	Fri, Nov 8, 2:54 AM

	Unknown Object (File)
	Fri, Nov 1, 7:41 PM

	Unknown Object (File)
	Oct 14 2024, 12:23 PM

	Unknown Object (File)
	Oct 14 2024, 12:23 PM

	Unknown Object (File)
	Oct 14 2024, 12:23 PM

	Unknown Object (File)
	Oct 14 2024, 12:22 PM

View All 68 Files

Subscribers

Details

Reviewers

varun
bartek

Commits

rCOMMbec3fcefbe5c: [terraform] move image config to aws_ecs and add custom image variable

Summary

This allows one to specify a custom keyserver image, making it more convenient for my case of testing keyserver images. Also moved where we specify the image to locals in aws_ecs as the image isn't keyserver primary specific and is shared also with keyserver secondary

Depends on D12862

Test Plan

terraform apply with custom image and without custom image

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 23 2024, 11:29 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 23 2024, 11:29 AM

will edited the summary of this revision. (Show Details)Jul 23 2024, 11:30 AM

Harbormaster completed remote builds in B30625: Diff 42720.Jul 23 2024, 11:45 AM

will requested review of this revision.Jul 23 2024, 11:45 AM

will added a child revision: D12868: [terraform] Rename `aws_ecs` to `keyserver_cluster` and move shared security group.Jul 24 2024, 5:56 AM

varun accepted this revision.Jul 24 2024, 11:15 AM

This revision is now accepted and ready to land.Jul 24 2024, 11:15 AM

rebase

Harbormaster completed remote builds in B30651: Diff 42747.Jul 24 2024, 12:50 PM

Closed by commit rCOMMbec3fcefbe5c: [terraform] move image config to aws_ecs and add custom image variable (authored by will). · Explain WhyJul 24 2024, 12:58 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMbec3fcefbe5c: [terraform] move image config to aws_ecs and add custom image variable.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

7 lines

keyserver_primary.tf

2 lines

6 lines

Diff 42720

services/terraform/self-host/aws_ecs.tf

Loading...

services/terraform/self-host/keyserver_primary.tf

Loading...

services/terraform/self-host/variables.tf

Loading...