Page MenuHomePhabricator
Differential D12875

[terraform] create separate lb security groups for landing and web
ClosedPublic
Actions

Authored by will on Jul 24 2024, 12:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:22 PM
Unknown Object (File)
Tue, Mar 18, 10:17 AM
Unknown Object (File)
Sun, Mar 16, 2:23 PM
Unknown Object (File)
Mar 6 2025, 5:49 AM
Unknown Object (File)
Mar 5 2025, 3:00 PM
Unknown Object (File)
Mar 4 2025, 8:09 PM
Unknown Object (File)
Feb 18 2025, 3:54 AM
Unknown Object (File)
Feb 18 2025, 3:40 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web
Summary

Originally used a shared lb-sg but this is a bad idea given that the disabling ingress approach for the migration script would disable traffic for the webapp and landing page, not just
the keyserver.

Depends on D12874

Test Plan

terraform apply and was able to access landing page and webapp at custom domains

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Jul 24 2024, 12:57 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 24 2024, 12:57 PM
Harbormaster completed remote builds in B30652: Diff 42749.Jul 24 2024, 1:15 PM
will requested review of this revision.Jul 24 2024, 1:15 PM
will added a child revision: D12876: [terraform] Making user created vpc false by default.Jul 24 2024, 1:17 PM
will added a child revision: D12877: [terraform] Update terraform.tfvars.example and use json format.Jul 24 2024, 1:19 PM
bartek accepted this revision.Jul 25 2024, 6:51 AM
bartek added inline comments.
services/terraform/self-host/landing.tf
168 ↗(On Diff #42749)

Can we be more specific here?

services/terraform/self-host/webapp.tf
168 ↗(On Diff #42749)

Can we be more specific here?

This revision is now accepted and ready to land.Jul 25 2024, 6:51 AM
will added inline comments.Jul 25 2024, 7:08 AM
services/terraform/self-host/landing.tf
168 ↗(On Diff #42749)

Thanks for catching that. Including in next rebase

services/terraform/self-host/webapp.tf
168 ↗(On Diff #42749)

Same as above. Including in next rebase

will updated this revision to Diff 42772.Jul 25 2024, 7:12 AM

update descriptions for landing and webapp security groups

Harbormaster failed remote builds in B30668: Diff 42772!Jul 25 2024, 7:13 AM
will updated this revision to Diff 42777.Jul 25 2024, 9:37 AM

rebase

Harbormaster failed remote builds in B30673: Diff 42777!Jul 25 2024, 9:39 AM
will updated this revision to Diff 42784.Jul 25 2024, 11:15 AM

rebase

Harbormaster completed remote builds in B30678: Diff 42784.Jul 25 2024, 11:32 AM
Closed by commit rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web (authored by will). · Explain WhyJul 25 2024, 2:22 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMfe8af3b57b72: [terraform] create separate lb security groups for landing and web.

Revision Contents
Changeset List

PathSize
services/
terraform/
self-host/
1 line
22 lines
22 lines

Diff 42777

View Options

services/terraform/self-host/aws_lb.tf

// @flow // @flow
'use strict'; 'use strict';
import { TurboModuleRegistry } from 'react-native'; import { TurboModuleRegistry } from 'react-native';
import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js'; import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js';
// codegen doesn't understand ArrayBuffers, so we need to map them to Objects // codegen doesn't understand ArrayBuffers, so we need to map them to Objects
type JSIArrayBuffer = Object; type JSIArrayBuffer = Object;
interface Spec extends TurboModule { interface Spec extends TurboModule {
// filesystem utils // filesystem utils
+writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>; +readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>;
+base64EncodeBuffer: (data: JSIArrayBuffer) => string; +base64EncodeBuffer: (data: JSIArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => JSIArrayBuffer;
// crypto utils // crypto utils
+sha256: (data: JSIArrayBuffer) => string; +sha256: (data: JSIArrayBuffer) => string;
} }
// for public interface, we use the correct types // for public interface, we use the correct types
export interface UtilsModuleSpec { export interface UtilsModuleSpec {
+writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<ArrayBuffer>; +readBufferFromFile: (path: string) => Promise<ArrayBuffer>;
+base64EncodeBuffer: (data: ArrayBuffer) => string; +base64EncodeBuffer: (data: ArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => ArrayBuffer;
+sha256: (data: ArrayBuffer) => string; +sha256: (data: ArrayBuffer) => string;
} }
export default (TurboModuleRegistry.getEnforcing<Spec>( export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommUtilsTurboModule', 'CommUtilsTurboModule',
): Spec); ): Spec);
View Options

services/terraform/self-host/landing.tf

// @flow // @flow
'use strict'; 'use strict';
import { TurboModuleRegistry } from 'react-native'; import { TurboModuleRegistry } from 'react-native';
import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js'; import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js';
// codegen doesn't understand ArrayBuffers, so we need to map them to Objects // codegen doesn't understand ArrayBuffers, so we need to map them to Objects
type JSIArrayBuffer = Object; type JSIArrayBuffer = Object;
interface Spec extends TurboModule { interface Spec extends TurboModule {
// filesystem utils // filesystem utils
+writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>; +readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>;
+base64EncodeBuffer: (data: JSIArrayBuffer) => string; +base64EncodeBuffer: (data: JSIArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => JSIArrayBuffer;
// crypto utils // crypto utils
+sha256: (data: JSIArrayBuffer) => string; +sha256: (data: JSIArrayBuffer) => string;
} }
// for public interface, we use the correct types // for public interface, we use the correct types
export interface UtilsModuleSpec { export interface UtilsModuleSpec {
+writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<ArrayBuffer>; +readBufferFromFile: (path: string) => Promise<ArrayBuffer>;
+base64EncodeBuffer: (data: ArrayBuffer) => string; +base64EncodeBuffer: (data: ArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => ArrayBuffer;
+sha256: (data: ArrayBuffer) => string; +sha256: (data: ArrayBuffer) => string;
} }
export default (TurboModuleRegistry.getEnforcing<Spec>( export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommUtilsTurboModule', 'CommUtilsTurboModule',
): Spec); ): Spec);
View Options

services/terraform/self-host/webapp.tf

// @flow // @flow
'use strict'; 'use strict';
import { TurboModuleRegistry } from 'react-native'; import { TurboModuleRegistry } from 'react-native';
import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js'; import type { TurboModule } from 'react-native/Libraries/TurboModule/RCTExport.js';
// codegen doesn't understand ArrayBuffers, so we need to map them to Objects // codegen doesn't understand ArrayBuffers, so we need to map them to Objects
type JSIArrayBuffer = Object; type JSIArrayBuffer = Object;
interface Spec extends TurboModule { interface Spec extends TurboModule {
// filesystem utils // filesystem utils
+writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: JSIArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>; +readBufferFromFile: (path: string) => Promise<JSIArrayBuffer>;
+base64EncodeBuffer: (data: JSIArrayBuffer) => string; +base64EncodeBuffer: (data: JSIArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => JSIArrayBuffer;
// crypto utils // crypto utils
+sha256: (data: JSIArrayBuffer) => string; +sha256: (data: JSIArrayBuffer) => string;
} }
// for public interface, we use the correct types // for public interface, we use the correct types
export interface UtilsModuleSpec { export interface UtilsModuleSpec {
+writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>; +writeBufferToFile: (path: string, data: ArrayBuffer) => Promise<void>;
+readBufferFromFile: (path: string) => Promise<ArrayBuffer>; +readBufferFromFile: (path: string) => Promise<ArrayBuffer>;
+base64EncodeBuffer: (data: ArrayBuffer) => string; +base64EncodeBuffer: (data: ArrayBuffer) => string;
+base64DecodeBuffer: (base64: string) => ArrayBuffer;
+sha256: (data: ArrayBuffer) => string; +sha256: (data: ArrayBuffer) => string;
} }
export default (TurboModuleRegistry.getEnforcing<Spec>( export default (TurboModuleRegistry.getEnforcing<Spec>(
'CommUtilsTurboModule', 'CommUtilsTurboModule',
): Spec); ): Spec);