Page MenuHomePhabricator
Differential D12881

[lib] DMOperationSpec for change thread settings operation
ClosedPublic
Actions

Authored by tomek on Jul 25 2024, 8:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 7:28 PM
Unknown Object (File)
Mon, Mar 17, 6:44 PM
Unknown Object (File)
Fri, Mar 14, 11:57 PM
Unknown Object (File)
Fri, Mar 14, 4:41 AM
Unknown Object (File)
Fri, Mar 14, 4:37 AM
Unknown Object (File)
Tue, Mar 11, 6:40 AM
Unknown Object (File)
Tue, Mar 11, 6:35 AM
Unknown Object (File)
Mar 7 2025, 1:38 AM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM7b01dce4fc6f: [lib] DMOperationSpec for change thread settings operation
Summary

Create the spec.

https://linear.app/comm/issue/ENG-8737/create-dmoperations-for-changesettingsmessageinfo

Depends on D12872

Test Plan

Tested that processing the operation with changed name and color results with these values being updated both in Redux and in the DB (on web).

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jul 25 2024, 8:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2024, 8:47 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2024, 8:48 AM
Harbormaster failed remote builds in B30669: Diff 42773!
tomek updated this revision to Diff 42776.Jul 25 2024, 8:59 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2024, 9:10 AM
Harbormaster failed remote builds in B30672: Diff 42776!
tomek updated this revision to Diff 42808.Jul 26 2024, 3:05 AM

Rebase

Harbormaster completed remote builds in B30692: Diff 42808.Jul 26 2024, 3:30 AM
tomek requested review of this revision.Jul 26 2024, 3:30 AM
tomek updated this revision to Diff 42823.Jul 26 2024, 4:38 AM

Rename

Harbormaster completed remote builds in B30706: Diff 42823.Jul 26 2024, 5:07 AM
tomek added a child revision: D12892: [lib] DMOperationSpec for update relationship operation.Jul 26 2024, 5:20 AM
inka added inline comments.Jul 26 2024, 6:32 AM
lib/shared/dm-ops/change-thread-settings-spec.js
82–91

Can we instead create a function that calculates the threadInfo for add members operation, and use it here and in addMembersSpec. I really don't like that we have a hidden dependency addMembersSpec implementation details (by checking for UPDATE_THREAD/JOIN_THREAD)

104–117

This looks like validation of the chats name. Can we have a function for this validation? It should probably be used in other places, like when we first get thread infos...
It also feels like we should do something if this check fails. If the current user is the one performing the update, they should probably be informed that the name is invalid.

128

It seems odd that all those things like color.toLowerCase() and const name = firstLine(untrimmedName); are performed on each client, not on the one creating the operation.

181

Should we set the unread status?

tomek updated this revision to Diff 42903.Jul 29 2024, 7:33 AM
tomek marked an inline comment as done.

Extract common logic

lib/shared/dm-ops/change-thread-settings-spec.js
82–91

Makes sense!

104–117

We're validating this on the client side in the inputs.

It also feels like we should do something if this check fails. If the current user is the one performing the update, they should probably be informed that the name is invalid.

Our UI should handle that. This code mostly protects us against clients who send invalid data.

128

I am not sure if we should trust other clients to send the correct data. Created a task https://linear.app/comm/issue/ENG-8907/validate-operations-input to track the validation.

Harbormaster completed remote builds in B30760: Diff 42903.Jul 29 2024, 7:50 AM
tomek added a child revision: D12921: [lib] Handle replies count.Jul 29 2024, 8:43 AM
tomek updated this revision to Diff 42933.Jul 30 2024, 3:00 AM

Fix the types

Harbormaster completed remote builds in B30788: Diff 42933.Jul 30 2024, 3:24 AM
inka accepted this revision.Jul 31 2024, 2:22 AM

Should we set the unread status?

lib/shared/dm-ops/change-thread-settings-spec.js
45 ↗(On Diff #42933)

Is this to make the ids unique?

This revision is now accepted and ready to land.Jul 31 2024, 2:22 AM
tomek added a comment.Jul 31 2024, 10:00 AM
In D12881#366124, @inka wrote:

Should we set the unread status?

Yes, you're right!

lib/shared/dm-ops/change-thread-settings-spec.js
45 ↗(On Diff #42933)

Yes. We perform the same operation on keyservers. I'm not sure if we have to do it, but it also doesn't hurt and is safer.

tomek planned changes to this revision.Aug 1 2024, 5:40 AM
tomek updated this revision to Diff 43018.Aug 1 2024, 5:53 AM

Set unread status and create a custom changes field

This revision is now accepted and ready to land.Aug 1 2024, 5:53 AM
tomek updated this revision to Diff 43019.Aug 1 2024, 5:56 AM

Revert validators change

Harbormaster failed remote builds in B30851: Diff 43018!Aug 1 2024, 6:06 AM
Harbormaster failed remote builds in B30852: Diff 43019!Aug 1 2024, 6:18 AM
ashoat added a comment.EditedAug 1 2024, 1:43 PM
In D12881#366279, @tomek wrote:
In D12881#366124, @inka wrote:

Should we set the unread status?

Yes, you're right!

I wonder if it would be better to handle this as a "side effect" of the main processDMOperation. We could take a similar approach to updating the replies count.

We would need to check all of the rawMessageInfos, as well as any messages in the updateInfos, to see if any new messages are introduced that aren't from the viewer. This could potentially be done in useProcessDMOperation. Potentially mergeUpdatesWithMessageInfos could be helpful for extracting the messages from the updates.

@tomek, what do you think? A unified approach would mitigate the risk of the programmer forgetting to handle it in a specific case, and it would reduce code duplication.

tomek added a comment.EditedAug 2 2024, 2:05 AM
In D12881#366497, @ashoat wrote:
In D12881#366279, @tomek wrote:
In D12881#366124, @inka wrote:

Should we set the unread status?

Yes, you're right!

I wonder if it would be better to handle this as a "side effect" of the main processDMOperation. We could take a similar approach to updating the replies count.

We would need to check all of the rawMessageInfos, as well as any messages in the updateInfos, to see if any new messages are introduced that aren't from the viewer. This could potentially be done in useProcessDMOperation. Potentially mergeUpdatesWithMessageInfos could be helpful for extracting the messages from the updates.

@tomek, what do you think? A unified approach would mitigate the risk of the programmer forgetting to handle it in a specific case, and it would reduce code duplication.

Makes sense! Created a task to track https://linear.app/comm/issue/ENG-8930/unify-the-approach-to-replies-count-and-unread-status-updates, because creating a new diff on top of this stack is more efficient than updating all the diffs.

Harbormaster completed remote builds in B30852: Diff 43019.Aug 2 2024, 2:08 AM
tomek edited the test plan for this revision. (Show Details)Aug 2 2024, 4:38 AM
Closed by commit rCOMM7b01dce4fc6f: [lib] DMOperationSpec for change thread settings operation (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM7b01dce4fc6f: [lib] DMOperationSpec for change thread settings operation.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
13 lines
lib/
shared/
dm-ops/
190 lines
2 lines
types/
31 lines
validators/
23 lines

Diff 42823

View Options

keyserver/src/responders/thread-responders.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/dm-op-specs.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/types/dm-ops.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/types/validators/thread-validators.js

Loading...