Differential D12954
[lib] Create an operation pruner Authored by tomek on Jul 31 2024, 10:50 AM. Tags None Referenced Files
Subscribers
Details
We should prune the operations periodically because their number can keep growing. Frequency and max age were chosen arbitrary, and I'm not sure if they are good. https://linear.app/comm/issue/ENG-8768/add-a-component-that-prunes-the-updates-periodically Depends on D12949 Queued some operations for two different threads with different timestamps. Modified pruner constants and verified that correct operations were removed.
Diff Detail
Event Timeline
Comment Actions I'm worried about a scenario where the user doesn't open the app for a couple of days, and when they do all ops are suddenly deleted before they can be processed. Are we protected against that somehow? Comment Actions That's a good question. The current solution isn't terrible because for an operation to appear in this queue, it needs to be unprocessable at some point (its thread isn't present in the store). Also, pruning the messages happens at the start of the app, which means that pending messages from tunnelbroker are unlikely to be received. But regardless, I think we can do better. Instead of relying on a timestamp from the operation, we could generate a new timestamp when putting it into the queue.
| ||||||||||||||||||||||||||||||||||||||||||||||||||