Page MenuHomePhabricator
Differential D12949

[lib] Create a new action and a reducer that queue the operations
ClosedPublic
Actions

Authored by tomek on Jul 30 2024, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 6:49 AM
Unknown Object (File)
Mon, Apr 7, 6:10 PM
Unknown Object (File)
Mar 7 2025, 12:37 PM
Unknown Object (File)
Mar 7 2025, 5:13 AM
Unknown Object (File)
Mar 4 2025, 10:31 PM
Unknown Object (File)
Mar 3 2025, 3:46 PM
Unknown Object (File)
Feb 27 2025, 12:37 AM
Unknown Object (File)
Feb 25 2025, 11:50 PM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMb0d7a3804c22: [lib] Create a new action and a reducer that queue the operations
Summary

Dispatch an action when an operation can't be processed. Add to a queue in the reducer.

https://linear.app/comm/issue/ENG-8916/create-a-new-action-and-a-reducer-that-queue-the-operations

Depends on D12948

Test Plan

Processed an operation for a missing thread and verified that it was added to the queue in Redux.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jul 30 2024, 9:53 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 9:53 AM
Harbormaster completed remote builds in B30821: Diff 42974.Jul 30 2024, 10:15 AM
tomek requested review of this revision.Jul 30 2024, 10:15 AM
inka accepted this revision.Jul 31 2024, 3:06 AM
This revision is now accepted and ready to land.Jul 31 2024, 3:06 AM
tomek added a child revision: D12954: [lib] Create an operation pruner.Jul 31 2024, 10:50 AM
tomek updated this revision to Diff 43037.Aug 2 2024, 4:50 AM

Fix result check

tomek edited the test plan for this revision. (Show Details)Aug 2 2024, 4:51 AM
Harbormaster completed remote builds in B30870: Diff 43037.Aug 2 2024, 5:07 AM
Closed by commit rCOMMb0d7a3804c22: [lib] Create a new action and a reducer that queue the operations (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMb0d7a3804c22: [lib] Create a new action and a reducer that queue the operations.
bartek mentioned this in D13403: [lib] Add reducer and action to store established holder.Sep 20 2024, 3:52 AM
bartek mentioned this in rCOMM79e2ffe30f49: [lib] Add reducer and action to store established holder.Sep 23 2024, 7:24 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
26 lines
5 lines
shared/
dm-ops/
11 lines
types/
6 lines
4 lines

Diff 43051

View Options

lib/reducers/dm-operations-queue-reducer.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/reducers/master-reducer.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/process-dm-ops.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/types/redux-types.js

Loading...