Page MenuHomePhabricator
Differential D12956

[lib] Apply the queued updates
ClosedPublic
Actions

Authored by tomek on Aug 1 2024, 10:15 AM.
Tags
None
Referenced Files
F3177483: D12956.diff
Thu, Nov 7, 11:31 PM
Unknown Object (File)
Wed, Nov 6, 11:18 PM
Unknown Object (File)
Wed, Nov 6, 11:17 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Tue, Oct 22, 1:17 PM
Unknown Object (File)
Tue, Oct 22, 8:33 AM
Unknown Object (File)
Tue, Oct 22, 8:33 AM
Unknown Object (File)
Tue, Oct 22, 8:33 AM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMff536cc87f89: [lib] Apply the queued updates
Summary

When a thread appears in the store, we should process all the operations that were queued for it.

https://linear.app/comm/issue/ENG-8769/apply-the-queued-updates

Depends on D12954

Test Plan

Processed an operation that updates thread name, with a thread ID that isn't present in the store. Then processed another operation that creates a thread with this ID. Checked that the name of the created thread matched the value from the first operation. Also checked that the queue no longer contains the operations.

Diff Detail

Repository
rCOMM Comm
Branch
dmops
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 1 2024, 10:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 1 2024, 10:15 AM
tomek added inline comments.Aug 1 2024, 10:17 AM
lib/shared/dm-ops/dm-ops-queue-handler.react.js
45 ↗(On Diff #43024)

We don't want to process operations multiple times. This ref allows us to process the operations in the first render where the thread is present.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 1 2024, 10:38 AM
Harbormaster failed remote builds in B30857: Diff 43024!
Harbormaster completed remote builds in B30857: Diff 43024.Aug 2 2024, 1:51 AM
tomek requested review of this revision.Aug 2 2024, 1:51 AM
tomek updated this revision to Diff 43035.Aug 2 2024, 2:50 AM

Rebase

Harbormaster completed remote builds in B30868: Diff 43035.Aug 2 2024, 3:07 AM
tomek added a child revision: D12957: [lib] Correctly handle generating ops from multiple updates.Aug 2 2024, 4:35 AM
tomek edited the test plan for this revision. (Show Details)Aug 2 2024, 6:37 AM
tomek edited the test plan for this revision. (Show Details)
inka accepted this revision.Aug 2 2024, 7:31 AM
inka added inline comments.
lib/shared/dm-ops/dm-ops-queue-handler.react.js
62

can't we iterate over queuedOperations entries?
for (const threadID in queuedOperations)

66–68

Can't we run ops in parallel?

lib/types/dm-ops.js
330

This name is very hard for me to understand. Can it be 'CLEAR_QUEUED_THREAD_DM_OPS'?

This revision is now accepted and ready to land.Aug 2 2024, 7:31 AM
tomek updated this revision to Diff 43039.Aug 2 2024, 7:44 AM

Rename. Run ops in parallel.

Harbormaster completed remote builds in B30872: Diff 43039.Aug 2 2024, 8:05 AM
tomek updated this revision to Diff 43040.Aug 2 2024, 8:10 AM

Run ops in parallel

Harbormaster completed remote builds in B30873: Diff 43040.Aug 2 2024, 8:27 AM
Closed by commit rCOMMff536cc87f89: [lib] Apply the queued updates (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMff536cc87f89: [lib] Apply the queued updates.

Revision Contents
Changeset List

PathSize
lib/
reducers/
8 lines
shared/
dm-ops/
89 lines
tunnelbroker/
4 lines
types/
5 lines
7 lines

Diff 43035

View Options

lib/reducers/dm-operations-queue-reducer.js

Loading...
View Options

lib/shared/dm-ops/dm-ops-queue-handler.react.js

Loading...
View Options

lib/shared/dm-ops/dm-ops-queue-pruner.react.js

Loading...
View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...
View Options

lib/types/dm-ops.js

Loading...
View Options

lib/types/redux-types.js

Loading...