When a thread appears in the store, we should process all the operations that were queued for it.
https://linear.app/comm/issue/ENG-8769/apply-the-queued-updates
Depends on D12954
Details
Details
- Reviewers
kamil inka - Commits
- rCOMMff536cc87f89: [lib] Apply the queued updates
Processed an operation that updates thread name, with a thread ID that isn't present in the store. Then processed another operation that creates a thread with this ID. Checked that the name of the created thread matched the value from the first operation. Also checked that the queue no longer contains the operations.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/dm-ops/dm-ops-queue-handler.react.js | ||
|---|---|---|
| 45 ↗ | (On Diff #43024) | We don't want to process operations multiple times. This ref allows us to process the operations in the first render where the thread is present. |
| lib/shared/dm-ops/dm-ops-queue-handler.react.js | ||
|---|---|---|
| 62 ↗ | (On Diff #43035) | can't we iterate over queuedOperations entries? |
| 66–68 ↗ | (On Diff #43035) | Can't we run ops in parallel? |
| lib/types/dm-ops.js | ||
| 330 ↗ | (On Diff #43035) | This name is very hard for me to understand. Can it be 'CLEAR_QUEUED_THREAD_DM_OPS'? |