[terraform] use module approach for landing
ClosedPublic
Actions

Authored by will on Jul 29 2024, 8:50 PM.

Details

Reviewers

varun
bartek

Commits

rCOMMa0bf6ca20ee0: [terraform] use module approach for landing

Summary

Similar to webapp, uses the module approach for landing.

Depends on D12928

Test Plan

terraform apply. Pointed domain and confirmed landing page is working

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 29 2024, 8:50 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 8:50 PM

Harbormaster completed remote builds in B30778: Diff 42921.Jul 29 2024, 9:10 PM

will requested review of this revision.Jul 29 2024, 9:10 PM

bartek accepted this revision.Jul 30 2024, 8:26 AM

This revision is now accepted and ready to land.Jul 30 2024, 8:26 AM

include default blank landing domain

Harbormaster completed remote builds in B30875: Diff 43055.Aug 4 2024, 7:28 PM

will added a child revision: D12930: [terraform] deploy landing on comm services cluster.Aug 5 2024, 12:01 PM

rebase before landing

Harbormaster completed remote builds in B30970: Diff 43199.Aug 6 2024, 7:11 PM

Closed by commit rCOMMa0bf6ca20ee0: [terraform] use module approach for landing (authored by will). · Explain WhyAug 6 2024, 7:43 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMa0bf6ca20ee0: [terraform] use module approach for landing.

Revision Contents
Changeset List

Path

Size

services/

terraform/

self-host/

landing.tf

187 lines

variables.tf

20 lines

Diff 43055

View Options

services/terraform/self-host/landing.tf