Page MenuHomePhabricator

[lib] Delete auxUserStore users on authoritative keyserver request
ClosedPublic

Authored by bartek on Aug 4 2024, 11:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 4:39 PM
Unknown Object (File)
Thu, Nov 7, 1:55 AM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Sat, Nov 2, 4:20 AM
Unknown Object (File)
Sat, Nov 2, 4:20 AM
Unknown Object (File)
Sat, Nov 2, 4:19 AM
Unknown Object (File)
Sat, Nov 2, 4:19 AM
Unknown Object (File)
Sat, Nov 2, 3:59 AM
Subscribers

Details

Summary

When a user deletes account, authoritative keyserver sends updates to known peers, which in user-reducer are processed and the user is deleted from their userStores.
We want the same for auxUserStore, when a peer deletes their account.

When relying on authoritative keyserver, we can simply copy the action to auxUserStore.
Scenario with relyingOnAuthoritativeKeyserve = false is handled in the next diff

Depends on D12945

Test Plan
  • Register two users and make sure they know about each other (have entries in user stores)
  • Delete account for one user
  • Make sure it gets removed from the other user's userStore and auxUserStore

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Aug 5 2024, 2:27 AM

Wondering how we should me sure we keep those two in sync to avoid cases like here.

This revision is now accepted and ready to land.Aug 5 2024, 4:49 AM
inka requested changes to this revision.Aug 5 2024, 5:15 AM
inka added inline comments.
lib/reducers/aux-user-reducer.js
187

Shouldn't we be returning removeUsersOps?

This revision now requires changes to proceed.Aug 5 2024, 5:15 AM
This revision is now accepted and ready to land.Aug 5 2024, 5:34 AM
This revision was landed with ongoing or failed builds.Aug 5 2024, 5:54 AM
This revision was automatically updated to reflect the committed changes.