This implements a module for the webapp and replaces the self-host webapp to use it
Depends on D12927
Details
Details
terraform apply. Webapp was accessible as prior to module implementation
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Nice! The code structure looks neat!
In the future we can do a similar thing to our ECS services - modules can help avoid lots of duplication.
The only thing I have mixed feelings is the name node_service - I think of it as a Node.js service (in fact it is) 😅 Could it be sth like keyserver_node_service? IDK
P.S. Have you tried terraform state mv or just killed old resources and restarted? :D Just curious, I'd do the latter
Comment Actions
I just killed the old resources and restarted. In this specific scenario, I think we're fine as we plan on moving landing and webapp to comm services instead Ashoat's self hosted setup.
I think a rename makes sense here, it's just that I wanted to separate the concept of a webapp and landing node from a keyserver node although they technically all run off the keyserver. I'll change it to keyserver_node_service for now