This implements a module for the webapp and replaces the self-host webapp to use it
Depends on D12927
Paths
| Differential D12906 Authored by will on Jul 28 2024, 5:52 PM.
Details Summary This implements a module for the webapp and replaces the self-host webapp to use it Depends on D12927 Test Plan terraform apply. Webapp was accessible as prior to module implementation
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptJul 28 2024, 5:52 PM2024-07-28 17:52:04 (UTC-7) Harbormaster completed remote builds in B30730: Diff 42856.Jul 28 2024, 6:08 PM2024-07-28 18:08:33 (UTC-7) Comment Actions Nice! The code structure looks neat! The only thing I have mixed feelings is the name node_service - I think of it as a Node.js service (in fact it is) 😅 Could it be sth like keyserver_node_service? IDK P.S. Have you tried terraform state mv or just killed old resources and restarted? :D Just curious, I'd do the latter This revision is now accepted and ready to land.Jul 28 2024, 11:55 PM2024-07-28 23:55:16 (UTC-7) Comment Actions
I just killed the old resources and restarted. In this specific scenario, I think we're fine as we plan on moving landing and webapp to comm services instead Ashoat's self hosted setup. I think a rename makes sense here, it's just that I wanted to separate the concept of a webapp and landing node from a keyserver node although they technically all run off the keyserver. I'll change it to keyserver_node_service for now will edited the summary of this revision. (Show Details)Aug 5 2024, 11:56 AM2024-08-05 11:56:18 (UTC-7) will added a parent revision: D12927: [keyserver] Do not verify identity logged for webapp and landing. Harbormaster failed remote builds in B30941: Diff 43156!Aug 5 2024, 12:19 PM2024-08-05 12:19:46 (UTC-7) Harbormaster completed remote builds in B30967: Diff 43196.Aug 6 2024, 6:56 PM2024-08-06 18:56:27 (UTC-7) Closed by commit rCOMM373d6c75fa93: [terraform] Create module for webapp/landing and convert webapp to module (authored by will). · Explain WhyAug 6 2024, 7:43 PM2024-08-06 19:43:01 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 43196 services/terraform/modules/keyserver_node_service/main.tf
services/terraform/modules/keyserver_node_service/outputs.tf
services/terraform/modules/keyserver_node_service/variables.tf
services/terraform/self-host/outputs.tf
services/terraform/self-host/variables.tf
services/terraform/self-host/webapp.tf
|