Details

Reviewers

bartek
varun

Commits

rCOMM42499907ef11: [keyserver] Run webapp through comm services cluster

Summary

Run webapp on the comm services cluster. Will not land until web.comm.app has been properly set up on prod

This will require a new keyserver image push with https://phab.comm.dev/D12927

Depends on D12906

Test Plan

terraform apply. Switched comm.software to point to web app load balancer and accessed the working web app.

Used wyilio/keysever:1.0 for testing

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 29 2024, 8:43 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 8:43 PM

will edited the summary of this revision. (Show Details)Jul 29 2024, 8:44 PM

will added a parent revision: D12927: [keyserver] Do not verify identity logged for webapp and landing.

will added inline comments.Jul 29 2024, 8:48 PM

services/terraform/remote/service_webapp.tf
19–25 ↗	(On Diff #42920)	This addresses the possibility for devs to not have the env file but detected if the file doesn't exist and creating it. This will cause the dev to have to terraform apply twice before resolving the missing .env file, but this shouldn't be too much of a problem. Tried using the sops provider but it strips `\`` from the env file so found this to be a working method. The `dotenv` also requires a `.env` file and it cannot be passed by value or sops @bartek Let me know if there's an easier way around this I'm missing

will added a child revision: D12929: [terraform] use module approach for landing.Jul 29 2024, 8:50 PM

move dotenv to env.tf

Harbormaster completed remote builds in B30777: Diff 42920.Jul 29 2024, 9:10 PM

will edited the summary of this revision. (Show Details)Jul 29 2024, 9:12 PM

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B30779: Diff 42922.Jul 29 2024, 9:13 PM

will requested review of this revision.Jul 29 2024, 9:13 PM

will edited the summary of this revision. (Show Details)Jul 29 2024, 9:15 PM

will added a child revision: D12930: [terraform] deploy landing on comm services cluster.

General question:
What's the advantage of sops-encrypting new .env files instead of reusing our sops_file resource for secrets.json, having webapp-specific config inside it, and then doing

webapp_environment_vars = merge(local.secrets.webapp_secrets,  { ... })

I'm not saying your approach is bad, I just want to understand the motivation

services/terraform/remote/aws_iam.tf
74 ↗	(On Diff #42922)	Here, in `remote`, this name is way too general. We have other "ecs task roles" for specific services (`"aws_iam_role" "feature_flags_service"`, `reports_service`) and some more general like `"services_ddb_full_access"`. So leaving this could be VERY confusing

In D12928#366013, @bartek wrote:
General question:
What's the advantage of sops-encrypting new .env files instead of reusing our sops_file resource for secrets.json, having webapp-specific config inside it, and then doing
webapp_environment_vars = merge(local.secrets.webapp_secrets,  { ... })
?

I'm not saying your approach is bad, I just want to understand the motivation

Wasn't something I exactly considered. I think my main motivation was keeping it as a .env format, but let me know if you think going with the secrets.json approach would be better. It would simplify the process of the null resource creating a .env file every time.

services/terraform/remote/aws_iam.tf
74 ↗	(On Diff #42922)	Got it. I'll rename it on next rebase

Planning to change .env to secrets.json approach

review feedback. use secrets.json approach instead of .env

will planned changes to this revision.Aug 1 2024, 11:18 AM

Harbormaster failed remote builds in B30858: Diff 43025!Aug 1 2024, 11:32 AM

full review feedback

Harbormaster failed remote builds in B30860: Diff 43027!Aug 1 2024, 12:23 PM

setting @bartek as blocking since he left the original feedback

will added inline comments.Aug 1 2024, 8:29 PM

services/terraform/remote/secrets.json
28–40 ↗	(On Diff #43027)	These are included later in the json file. I'll remove before landing

bartek accepted this revision.Aug 2 2024, 10:35 AM

bartek added inline comments.

services/terraform/remote/secrets.json
91 ↗	(On Diff #43027)	Was the KMS key somehow auto-regenerated? I guess you didn't modify anything since the `arn` remains unchanged

This revision is now accepted and ready to land.Aug 2 2024, 10:35 AM

will removed a parent revision: D12927: [keyserver] Do not verify identity logged for webapp and landing.Aug 5 2024, 11:54 AM

will edited the summary of this revision. (Show Details)Aug 5 2024, 11:57 AM

will edited the summary of this revision. (Show Details)

will added a parent revision: D12906: [terraform] Create module for webapp/landing and convert webapp to module.

will removed a child revision: D12930: [terraform] deploy landing on comm services cluster.Aug 5 2024, 12:00 PM

will added inline comments.Aug 6 2024, 6:39 PM

services/terraform/remote/secrets.json
91 ↗	(On Diff #43027)	Did not modify the KMS key

rebase before landing

move up image to 103

Harbormaster completed remote builds in B30968: Diff 43197.Aug 6 2024, 7:00 PM

Harbormaster completed remote builds in B30969: Diff 43198.Aug 6 2024, 7:03 PM

Closed by commit rCOMM42499907ef11: [keyserver] Run webapp through comm services cluster (authored by will). · Explain WhyAug 6 2024, 7:43 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM42499907ef11: [keyserver] Run webapp through comm services cluster.

Diff 43198

View Options

services/terraform/remote/aws_iam.tf

Show All 20 Lines	import {
type EditMessageContent,		type EditMessageContent,
type MessageSelectionCriteria,		type MessageSelectionCriteria,
type MessageTruncationStatus,		type MessageTruncationStatus,
messageTruncationStatus,		messageTruncationStatus,
type FetchMessageInfosResult,		type FetchMessageInfosResult,
defaultMaxMessageAge,		defaultMaxMessageAge,
type FetchPinnedMessagesRequest,		type FetchPinnedMessagesRequest,
type FetchPinnedMessagesResult,		type FetchPinnedMessagesResult,
isMessageSidebarSourceReactionOrEdit,		isMessageSidebarSourceReactionEditOrPin,
type SearchMessagesResponse,		type SearchMessagesResponse,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultNumberPerThread } from 'lib/types/message-types.js';		import { defaultNumberPerThread } from 'lib/types/message-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';

import {		import {
constructMediaFromMediaMessageContentsAndUploadRows,		constructMediaFromMediaMessageContentsAndUploadRows,
▲ Show 20 Lines • Show All 702 Lines • ▼ Show 20 Lines	const [result, edits] = await Promise.all([
fetchMessageRowsByIDs([...requiredIDs]),		fetchMessageRowsByIDs([...requiredIDs]),
fetchLatestEditMessageContentByIDs([...requiredIDs]),		fetchLatestEditMessageContentByIDs([...requiredIDs]),
]);		]);
const messages = await parseMessageSQLResult(result, new Map(), viewer);		const messages = await parseMessageSQLResult(result, new Map(), viewer);

for (const message of messages) {		for (const message of messages) {
let { rawMessageInfo } = message;		let { rawMessageInfo } = message;
invariant(		invariant(
!isMessageSidebarSourceReactionOrEdit(rawMessageInfo),		!isMessageSidebarSourceReactionEditOrPin(rawMessageInfo),
'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +		'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +
'SIDEBAR_SOURCE, REACTION or EDIT_MESSAGE',		'SIDEBAR_SOURCE, REACTION, EDIT_MESSAGE or TOGGLE_PIN',
);		);
if (rawMessageInfo.id) {		if (rawMessageInfo.id) {
const editedContent = edits.get(rawMessageInfo.id);		const editedContent = edits.get(rawMessageInfo.id);
if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {		if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {
rawMessageInfo = {		rawMessageInfo = {
...rawMessageInfo,		...rawMessageInfo,
text: editedContent.text,		text: editedContent.text,
};		};
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	const query = SQL`
FROM messages m		FROM messages m
LEFT JOIN uploads up ON up.container = m.id		LEFT JOIN uploads up ON up.container = m.id
LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}		LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}
AND stm.thread = m.content AND stm.user = m.user		AND stm.thread = m.content AND stm.user = m.user
WHERE m.target_message IN (${originalMessageIDs})		WHERE m.target_message IN (${originalMessageIDs})
AND (		AND (
m.type = ${messageTypes.SIDEBAR_SOURCE}		m.type = ${messageTypes.SIDEBAR_SOURCE}
OR m.type = ${messageTypes.REACTION}		OR m.type = ${messageTypes.REACTION}
		OR m.type = ${messageTypes.TOGGLE_PIN}
)		)
UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,		UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,
m.creation, m.user AS creatorID, m.target_message as targetMessageID,		m.creation, m.user AS creatorID, m.target_message as targetMessageID,
stm.permissions AS subthread_permissions, up.id AS uploadID,		stm.permissions AS subthread_permissions, up.id AS uploadID,
up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra		up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra
FROM messages m2		FROM messages m2
INNER JOIN messages m ON m.id = (		INNER JOIN messages m ON m.id = (
SELECT m3.id FROM messages m3		SELECT m3.id FROM messages m3
Show All 24 Lines
): Promise<$ReadOnlyArray<RawMessageInfo>> {		): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);		const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<		const rawMessageInfoMap = new Map<
string,		string,
RawComposableMessageInfo \| RawRobotextMessageInfo,		RawComposableMessageInfo \| RawRobotextMessageInfo,
>();		>();
for (const message of parsedResults) {		for (const message of parsedResults) {
const { rawMessageInfo } = message;		const { rawMessageInfo } = message;
if (isMessageSidebarSourceReactionOrEdit(rawMessageInfo)) {		if (isMessageSidebarSourceReactionEditOrPin(rawMessageInfo)) {
continue;		continue;
}		}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');		invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);		rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}		}

const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);		const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(		const rawRelatedMessageInfos = await fetchRelatedMessages(
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

View Options

services/terraform/remote/secrets.json

Show All 20 Lines	import {
type EditMessageContent,		type EditMessageContent,
type MessageSelectionCriteria,		type MessageSelectionCriteria,
type MessageTruncationStatus,		type MessageTruncationStatus,
messageTruncationStatus,		messageTruncationStatus,
type FetchMessageInfosResult,		type FetchMessageInfosResult,
defaultMaxMessageAge,		defaultMaxMessageAge,
type FetchPinnedMessagesRequest,		type FetchPinnedMessagesRequest,
type FetchPinnedMessagesResult,		type FetchPinnedMessagesResult,
isMessageSidebarSourceReactionOrEdit,		isMessageSidebarSourceReactionEditOrPin,
type SearchMessagesResponse,		type SearchMessagesResponse,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultNumberPerThread } from 'lib/types/message-types.js';		import { defaultNumberPerThread } from 'lib/types/message-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';

import {		import {
constructMediaFromMediaMessageContentsAndUploadRows,		constructMediaFromMediaMessageContentsAndUploadRows,
▲ Show 20 Lines • Show All 702 Lines • ▼ Show 20 Lines	const [result, edits] = await Promise.all([
fetchMessageRowsByIDs([...requiredIDs]),		fetchMessageRowsByIDs([...requiredIDs]),
fetchLatestEditMessageContentByIDs([...requiredIDs]),		fetchLatestEditMessageContentByIDs([...requiredIDs]),
]);		]);
const messages = await parseMessageSQLResult(result, new Map(), viewer);		const messages = await parseMessageSQLResult(result, new Map(), viewer);

for (const message of messages) {		for (const message of messages) {
let { rawMessageInfo } = message;		let { rawMessageInfo } = message;
invariant(		invariant(
!isMessageSidebarSourceReactionOrEdit(rawMessageInfo),		!isMessageSidebarSourceReactionEditOrPin(rawMessageInfo),
'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +		'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +
'SIDEBAR_SOURCE, REACTION or EDIT_MESSAGE',		'SIDEBAR_SOURCE, REACTION, EDIT_MESSAGE or TOGGLE_PIN',
);		);
if (rawMessageInfo.id) {		if (rawMessageInfo.id) {
const editedContent = edits.get(rawMessageInfo.id);		const editedContent = edits.get(rawMessageInfo.id);
if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {		if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {
rawMessageInfo = {		rawMessageInfo = {
...rawMessageInfo,		...rawMessageInfo,
text: editedContent.text,		text: editedContent.text,
};		};
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	const query = SQL`
FROM messages m		FROM messages m
LEFT JOIN uploads up ON up.container = m.id		LEFT JOIN uploads up ON up.container = m.id
LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}		LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}
AND stm.thread = m.content AND stm.user = m.user		AND stm.thread = m.content AND stm.user = m.user
WHERE m.target_message IN (${originalMessageIDs})		WHERE m.target_message IN (${originalMessageIDs})
AND (		AND (
m.type = ${messageTypes.SIDEBAR_SOURCE}		m.type = ${messageTypes.SIDEBAR_SOURCE}
OR m.type = ${messageTypes.REACTION}		OR m.type = ${messageTypes.REACTION}
		OR m.type = ${messageTypes.TOGGLE_PIN}
)		)
UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,		UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,
m.creation, m.user AS creatorID, m.target_message as targetMessageID,		m.creation, m.user AS creatorID, m.target_message as targetMessageID,
stm.permissions AS subthread_permissions, up.id AS uploadID,		stm.permissions AS subthread_permissions, up.id AS uploadID,
up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra		up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra
FROM messages m2		FROM messages m2
INNER JOIN messages m ON m.id = (		INNER JOIN messages m ON m.id = (
SELECT m3.id FROM messages m3		SELECT m3.id FROM messages m3
Show All 24 Lines
): Promise<$ReadOnlyArray<RawMessageInfo>> {		): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);		const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<		const rawMessageInfoMap = new Map<
string,		string,
RawComposableMessageInfo \| RawRobotextMessageInfo,		RawComposableMessageInfo \| RawRobotextMessageInfo,
>();		>();
for (const message of parsedResults) {		for (const message of parsedResults) {
const { rawMessageInfo } = message;		const { rawMessageInfo } = message;
if (isMessageSidebarSourceReactionOrEdit(rawMessageInfo)) {		if (isMessageSidebarSourceReactionEditOrPin(rawMessageInfo)) {
continue;		continue;
}		}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');		invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);		rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}		}

const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);		const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(		const rawRelatedMessageInfos = await fetchRelatedMessages(
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

View Options

services/terraform/remote/service_webapp.tf

Show All 20 Lines	import {
type EditMessageContent,		type EditMessageContent,
type MessageSelectionCriteria,		type MessageSelectionCriteria,
type MessageTruncationStatus,		type MessageTruncationStatus,
messageTruncationStatus,		messageTruncationStatus,
type FetchMessageInfosResult,		type FetchMessageInfosResult,
defaultMaxMessageAge,		defaultMaxMessageAge,
type FetchPinnedMessagesRequest,		type FetchPinnedMessagesRequest,
type FetchPinnedMessagesResult,		type FetchPinnedMessagesResult,
isMessageSidebarSourceReactionOrEdit,		isMessageSidebarSourceReactionEditOrPin,
type SearchMessagesResponse,		type SearchMessagesResponse,
} from 'lib/types/message-types.js';		} from 'lib/types/message-types.js';
import { defaultNumberPerThread } from 'lib/types/message-types.js';		import { defaultNumberPerThread } from 'lib/types/message-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js';		import { threadPermissions } from 'lib/types/thread-permission-types.js';
import { ServerError } from 'lib/utils/errors.js';		import { ServerError } from 'lib/utils/errors.js';

import {		import {
constructMediaFromMediaMessageContentsAndUploadRows,		constructMediaFromMediaMessageContentsAndUploadRows,
▲ Show 20 Lines • Show All 702 Lines • ▼ Show 20 Lines	const [result, edits] = await Promise.all([
fetchMessageRowsByIDs([...requiredIDs]),		fetchMessageRowsByIDs([...requiredIDs]),
fetchLatestEditMessageContentByIDs([...requiredIDs]),		fetchLatestEditMessageContentByIDs([...requiredIDs]),
]);		]);
const messages = await parseMessageSQLResult(result, new Map(), viewer);		const messages = await parseMessageSQLResult(result, new Map(), viewer);

for (const message of messages) {		for (const message of messages) {
let { rawMessageInfo } = message;		let { rawMessageInfo } = message;
invariant(		invariant(
!isMessageSidebarSourceReactionOrEdit(rawMessageInfo),		!isMessageSidebarSourceReactionEditOrPin(rawMessageInfo),
'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +		'SIDEBAR_SOURCE or TOGGLE_PIN should not point to a ' +
'SIDEBAR_SOURCE, REACTION or EDIT_MESSAGE',		'SIDEBAR_SOURCE, REACTION, EDIT_MESSAGE or TOGGLE_PIN',
);		);
if (rawMessageInfo.id) {		if (rawMessageInfo.id) {
const editedContent = edits.get(rawMessageInfo.id);		const editedContent = edits.get(rawMessageInfo.id);
if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {		if (editedContent && rawMessageInfo.type === messageTypes.TEXT) {
rawMessageInfo = {		rawMessageInfo = {
...rawMessageInfo,		...rawMessageInfo,
text: editedContent.text,		text: editedContent.text,
};		};
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	const query = SQL`
FROM messages m		FROM messages m
LEFT JOIN uploads up ON up.container = m.id		LEFT JOIN uploads up ON up.container = m.id
LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}		LEFT JOIN memberships stm ON m.type = ${messageTypes.CREATE_SUB_THREAD}
AND stm.thread = m.content AND stm.user = m.user		AND stm.thread = m.content AND stm.user = m.user
WHERE m.target_message IN (${originalMessageIDs})		WHERE m.target_message IN (${originalMessageIDs})
AND (		AND (
m.type = ${messageTypes.SIDEBAR_SOURCE}		m.type = ${messageTypes.SIDEBAR_SOURCE}
OR m.type = ${messageTypes.REACTION}		OR m.type = ${messageTypes.REACTION}
		OR m.type = ${messageTypes.TOGGLE_PIN}
)		)
UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,		UNION SELECT m.id, m.thread AS threadID, m.content, m.time, m.type,
m.creation, m.user AS creatorID, m.target_message as targetMessageID,		m.creation, m.user AS creatorID, m.target_message as targetMessageID,
stm.permissions AS subthread_permissions, up.id AS uploadID,		stm.permissions AS subthread_permissions, up.id AS uploadID,
up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra		up.type AS uploadType, up.secret AS uploadSecret, up.extra AS uploadExtra
FROM messages m2		FROM messages m2
INNER JOIN messages m ON m.id = (		INNER JOIN messages m ON m.id = (
SELECT m3.id FROM messages m3		SELECT m3.id FROM messages m3
Show All 24 Lines
): Promise<$ReadOnlyArray<RawMessageInfo>> {		): Promise<$ReadOnlyArray<RawMessageInfo>> {
const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);		const parsedResults = await parseMessageSQLResult(rows, new Map(), viewer);
const rawMessageInfoMap = new Map<		const rawMessageInfoMap = new Map<
string,		string,
RawComposableMessageInfo \| RawRobotextMessageInfo,		RawComposableMessageInfo \| RawRobotextMessageInfo,
>();		>();
for (const message of parsedResults) {		for (const message of parsedResults) {
const { rawMessageInfo } = message;		const { rawMessageInfo } = message;
if (isMessageSidebarSourceReactionOrEdit(rawMessageInfo)) {		if (isMessageSidebarSourceReactionEditOrPin(rawMessageInfo)) {
continue;		continue;
}		}
invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');		invariant(rawMessageInfo.id, 'rawMessageInfo.id should not be null');
rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);		rawMessageInfoMap.set(rawMessageInfo.id, rawMessageInfo);
}		}

const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);		const rawMessageInfos = parsedResults.map(item => item.rawMessageInfo);
const rawRelatedMessageInfos = await fetchRelatedMessages(		const rawRelatedMessageInfos = await fetchRelatedMessages(
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines

[keyserver] Run webapp through comm services cluster
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43198

services/terraform/remote/aws_iam.tf

services/terraform/remote/secrets.json

services/terraform/remote/service_webapp.tf

[keyserver] Run webapp through comm services clusterClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43198

services/terraform/remote/aws_iam.tf

services/terraform/remote/secrets.json

services/terraform/remote/service_webapp.tf

[keyserver] Run webapp through comm services cluster
ClosedPublic
Actions

Revision Contents
Changeset List