Page MenuHomePhabricator
Differential D13055

[lib] Allow sending messages to some users
ClosedPublic
Actions

Authored by tomek on Aug 12 2024, 9:06 AM.
Tags
None
Referenced Files
F6234953: D13055.id43520.diff
Thu, Apr 24, 1:53 PM
Unknown Object (File)
Sat, Apr 12, 7:05 PM
Unknown Object (File)
Fri, Apr 11, 5:19 AM
Unknown Object (File)
Fri, Apr 4, 8:53 AM
Unknown Object (File)
Fri, Apr 4, 3:49 AM
Unknown Object (File)
Fri, Apr 4, 1:21 AM
Unknown Object (File)
Wed, Apr 2, 11:13 PM
Unknown Object (File)
Sun, Mar 30, 3:03 AM
View All 67 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM18ddf9534ce1: [lib] Allow sending messages to some users
Summary

We need this because we plan to send a different message to users who are added to a thread and to users who already were members, when we add new members.

https://linear.app/comm/issue/ENG-8929/split-add-members-operation

Depends on D13053

Test Plan

Checked two scenarios:
Open two clients with two different users logged in. Send two messages, one with the user included and one without. Check if only one message was delivered.

Diff Detail

Repository
rCOMM Comm
Branch
dmops
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
11 lines

Diff 43321

View Options

lib/shared/dm-ops/dm-op-utils.js

Show First 20 Lines • Show All 110 Lines • ▼ Show 20 Lines SELECT id AS uploadID, secret AS uploadSecret,
type AS uploadType, extra AS uploadExtra type AS uploadType, extra AS uploadExtra
FROM uploads FROM uploads
WHERE id IN (${mediaIDs}) AND uploader = ${viewer.id} AND container IS NULL WHERE id IN (${mediaIDs}) AND uploader = ${viewer.id} AND container IS NULL
`; `;
const [result] = await dbQuery(query); const [result] = await dbQuery(query);
return result.map(mediaFromRow); return result.map(mediaFromRow);
} }
async function fetchMediaForThread(
threadID: string,
limit: number,
offset: number,
): Promise<$ReadOnlyArray<Media>> {
const limitQuery = SQL`LIMIT ${limit} `;
const offsetQuery = SQL`OFFSET ${offset} `;
const query = SQL`
SELECT id AS uploadID, secret AS uploadSecret,
type AS uploadType, extra AS uploadExtra
FROM uploads
WHERE thread = ${threadID} AND filename NOT LIKE 'thumb%'
ORDER BY creation_time DESC
`
.append(limitQuery)
.append(offsetQuery);
const [uploads] = await dbQuery(query);
return uploads.map(mediaFromRow);
}
async function fetchUploadsForMessage( async function fetchUploadsForMessage(
viewer: Viewer, viewer: Viewer,
mediaMessageContents: $ReadOnlyArray<MediaMessageServerDBContent>, mediaMessageContents: $ReadOnlyArray<MediaMessageServerDBContent>,
): Promise<$ReadOnlyArray<Object>> { ): Promise<$ReadOnlyArray<Object>> {
const uploadIDs = getUploadIDsFromMediaMessageServerDBContents( const uploadIDs = getUploadIDsFromMediaMessageServerDBContents(
mediaMessageContents, mediaMessageContents,
); );
const query = SQL` const query = SQL`
▲ Show 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
export { export {
fetchUpload, fetchUpload,
fetchUploadChunk, fetchUploadChunk,
getUploadSize, getUploadSize,
getUploadURL, getUploadURL,
mediaFromRow, mediaFromRow,
fetchMedia, fetchMedia,
fetchMediaForThread,
fetchMediaFromMediaMessageContent, fetchMediaFromMediaMessageContent,
constructMediaFromMediaMessageContentsAndUploadRows, constructMediaFromMediaMessageContentsAndUploadRows,
}; };