Page MenuHomePhabricator

[lib] create session with peer only when it is missing
ClosedPublic

Authored by kamil on Aug 8 2024, 4:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 11:09 AM
Unknown Object (File)
Sun, Nov 10, 9:24 AM
Unknown Object (File)
Fri, Nov 8, 11:05 PM
Unknown Object (File)
Fri, Nov 8, 1:12 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Oct 10 2024, 12:49 PM
Subscribers

Details

Summary

ENG-6982.

ENG-8527.

We definitely shouldn't attempt to create a session when sending a message using Tunnelbroker fails.
According to Olm docs encrypt could throw only two errors:

  • NOT_ENOUGH_RANDOM
  • OUTPUT_BUFFER_TOO_SMALL

and attempting to create a session for those two is not to attempt new session creation, the only case is when the session is missing.

The alternative is to not update the code because peerOlmSessionsCreator is idempotent but we can avoid additional worker/CommCoreModule calls.

Depends on D13025

Test Plan

Test that when session is missing, it is created.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable