Differential D13030

[native] introduce resetting Outbound P2P Messages to `CommCoreModule`
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 11:26 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM12da08a568d6: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`

Summary

The code on native to interface with search API using JSI.

Depends on D13029

Test Plan

Tested in D13032

Diff Detail

Repository

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 8 2024, 11:26 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 11:26 AM

Harbormaster failed remote builds in B31009: Diff 43258!Aug 8 2024, 11:49 AM

kamil added a child revision: D13031: [lib] introduce resetting Outbound P2P Messages to `SQLiteAPI`.Aug 8 2024, 12:07 PM

kamil published this revision for review.Aug 8 2024, 12:30 PM

kamil edited the test plan for this revision. (Show Details)

tomek accepted this revision.Aug 12 2024, 8:17 AM

tomek added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2885–2892 ↗	(On Diff #43258)	We're doing something similar in a lot of places. Might be a good idea to introduce some utils for std collections <-> jsi collections conversions. (But we shouldn't prioritize it soon)

This revision is now accepted and ready to land.Aug 12 2024, 8:17 AM

add transaction

kamil added inline comments.Aug 13 2024, 10:50 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
2885–2892 ↗	(On Diff #43258)	ENG-9033

Harbormaster completed remote builds in B31056: Diff 43327.Aug 13 2024, 10:57 AM

Closed by commit rCOMM12da08a568d6: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`. · Explain WhyAug 13 2024, 11:10 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM12da08a568d6: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommCoreModule.h

4 lines

CommCoreModule.cpp

48 lines

_generated/

commJSI-generated.cpp

schema/

CommCoreModuleSchema.js

3 lines

Diff 43327

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...

native/cpp/CommonCpp/_generated/commJSI.h

Loading...

native/schema/CommCoreModuleSchema.js

Loading...