Page MenuHomePhabricator

[SQLite] implement resetting Outbound P2P messages
ClosedPublic

Authored by kamil on Aug 8 2024, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 10:12 AM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Mon, Oct 14, 7:19 PM
Unknown Object (File)
Oct 3 2024, 4:16 AM
Unknown Object (File)
Sep 18 2024, 9:25 PM
Unknown Object (File)
Sep 7 2024, 1:47 PM
Unknown Object (File)
Sep 7 2024, 11:37 AM
Subscribers

Details

Summary

ENG-6982.

It is possible to do it as one query but will be more complicated and less readable, I can update if reviewers think it worth it.

Each query is described in code comments.

Test Plan

Tests

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 8 2024, 5:06 AM
tomek added inline comments.
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611 ↗(On Diff #43256)

What happens if one of them succeeds and one fails?

This revision is now accepted and ready to land.Aug 12 2024, 1:11 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
2580–2611 ↗(On Diff #43256)

good call, I am going to wrap this in transaction in the following diffs