[terraform] include keyserver logs on keyserver init for qr code for self-host aws-deploy script
ClosedPublic
Actions

Authored by will on Aug 15 2024, 9:09 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM5578307107f7: [terraform] include keyserver logs on keyserver init for qr code for self-host…

Summary

This prints the logs for the primary keyserver so user can access the QR code

Depends on D13095

Test Plan

ran a fresh keyserver deploy and was able to print the qr code

The output:

Diff Detail

Repository

rCOMM Comm

Branch

script_changes

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Aug 15 2024, 9:09 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2024, 9:09 PM

will retitled this revision from [terraform] include keyserver logs on keyserver init for qr code to [terraform] include keyserver logs on keyserver init for qr code for self-host aws-deploy script.Aug 15 2024, 9:09 PM

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B31120: Diff 43417.Aug 15 2024, 9:26 PM

will requested review of this revision.Aug 15 2024, 9:26 PM

how'd you decide on --since 1d?

This revision is now accepted and ready to land.Aug 15 2024, 10:50 PM

In D13096#369718, @varun wrote:

how'd you decide on --since 1d?

I can make this shorter if needed, however I just over estimated just to be safe. Given that the the keyserver was only just initialized, I don't think there's a danger that the user would receive a huge influx in logs. It should only just be the logs when one first runs the keyserver.

@varun do you think we can keep it as is or make it something like 1 hr

I think it's fine, was just curious

Closed by commit rCOMM5578307107f7: [terraform] include keyserver logs on keyserver init for qr code for self-host… (authored by will). · Explain WhyAug 16 2024, 1:15 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM5578307107f7: [terraform] include keyserver logs on keyserver init for qr code for self-host….