Page MenuHomePhabricator

[terraform] remove unnecessary redeploy
ClosedPublic

Authored by will on Aug 15 2024, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Sep 25 2024, 1:31 AM
Unknown Object (File)
Sep 25 2024, 1:31 AM
Unknown Object (File)
Sep 25 2024, 1:29 AM
Unknown Object (File)
Sep 25 2024, 12:27 AM
Subscribers

Details

Summary

These parts of the script are no longer necessary as they are taken care of by
the terraform apply. Originally had the redeployment to take care of redeploying
the primary service after all nodes were taken down, but terraform apply already restores 1 desired node for primary.

Additionally, when the image is updated to a new one (which currently is assumed to cause a migration), local provisioner logic
in the terraform apply will ensure that the primary service is available before the secondary service is launched

Depends on D13094

Test Plan

ran the script and confirmed migration occurred successfully and secondary nodes only applied after primary node was healthy

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable