Page MenuHomePhabricator

[lib] Propagate MEMBER permissions to all chats in a community
ClosedPublic

Authored by ashoat on Aug 19 2024, 8:24 AM.
Tags
None
Referenced Files
F3203119: D13113.id43461.diff
Sat, Nov 9, 7:18 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:01 PM
Unknown Object (File)
Sat, Oct 19, 2:32 PM
Unknown Object (File)
Oct 2 2024, 8:13 AM
Unknown Object (File)
Oct 1 2024, 3:44 AM
Unknown Object (File)
Oct 1 2024, 3:44 AM
Subscribers
None

Details

Summary

This addresses ENG-9054.

The issue is that in D13014, I return false from includeThreadPermissionForThreadType even if a propagation prefix is set.

We want role permissions to apply to all chats in a community, even if there is a "broken link" where you are a member of a grandchild but not a member of its parent.

Depends on D13112

Test Plan
  1. I set up a repro of the issue in my local environment
  2. I applied this diff to fix the issue
  3. I reset db_version to 67 to trigger migration 68 again
  4. After migration 68 ran again, I confirmed that the issue was gone

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/permissions
Lint
No Lint Coverage
Unit
No Test Coverage