Page MenuHomePhabricator
Differential D13171

[lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`
ClosedPublic
Actions

Authored by kamil on Aug 26 2024, 9:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 3:47 PM
Unknown Object (File)
Feb 19 2025, 3:00 PM
Unknown Object (File)
Feb 17 2025, 3:51 AM
Unknown Object (File)
Feb 1 2025, 10:13 AM
Unknown Object (File)
Jan 30 2025, 2:53 PM
Unknown Object (File)
Jan 30 2025, 2:53 PM
Unknown Object (File)
Jan 15 2025, 11:20 AM
Unknown Object (File)
Jan 11 2025, 2:16 AM
View All 70 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`
Summary

https://phab.comm.dev/D13025#inline-75566

Test Plan

Build app, Flow, search for usage of SESSION_DOES_NOT_EXISTS and sessionDoesNotExists to make sure all are removed

Diff Detail

Repository
rCOMM Comm
Branch
fix-typo
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 26 2024, 9:09 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 26 2024, 9:09 AM
Harbormaster failed remote builds in B31270: Diff 43662!Aug 26 2024, 9:30 AM
kamil updated this revision to Diff 43665.Aug 27 2024, 2:16 AM

update

Harbormaster completed remote builds in B31273: Diff 43665.Aug 27 2024, 2:33 AM
kamil published this revision for review.Aug 28 2024, 5:56 AM
tomek accepted this revision.Aug 28 2024, 6:24 AM
This revision is now accepted and ready to land.Aug 28 2024, 6:24 AM
kamil mentioned this in D13025: [web][native] unify errors from `CryptoModule` on web and native.Sep 6 2024, 1:06 AM
kamil updated this revision to Diff 43908.Sep 6 2024, 1:21 AM

rebase

Harbormaster completed remote builds in B31444: Diff 43908.Sep 6 2024, 1:49 AM
Closed by commit rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST` (authored by kamil). · Explain WhySep 6 2024, 1:51 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
4 lines
utils/
2 lines
native/
cpp/
CommonCpp/
CryptoTools/
6 lines
web/
shared-worker/
worker/
8 lines

Diff 43665

View Options

lib/tunnelbroker/peer-to-peer-context.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

lib/utils/olm-utils.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}
View Options

web/shared-worker/worker/worker-crypto.js

use tracing::error;
pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>; pub type BoxedError = Box<dyn std::error::Error + Send + Sync + 'static>;
#[derive( #[derive(
Debug, derive_more::Display, derive_more::From, derive_more::Error, Debug, derive_more::Display, derive_more::From, derive_more::Error,
)] )]
pub enum WebsocketError { pub enum WebsocketError {
InvalidMessage, InvalidMessage,
InvalidSearchQuery,
UnauthorizedDevice, UnauthorizedDevice,
SendError, SendError,
SearchError, SearchError,
AuthError, AuthError,
SerializationError, SerializationError,
} }
impl From<serde_json::Error> for WebsocketError {
fn from(err: serde_json::Error) -> Self {
tracing::error!("Error serializing: {}", err);
WebsocketError::SerializationError
}
}
impl From<reqwest::Error> for WebsocketError {
fn from(err: reqwest::Error) -> Self {
tracing::error!("Error with search request: {}", err);
WebsocketError::SearchError
}
}