[terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet
ClosedPublic
Actions

Authored by bartek on Sep 5 2024, 1:26 AM.

Details

Reviewers

will
kamil

Commits

rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet

Summary

Addresses a part of ENG-9129.

This stops exposing publicly the Tunnelbroker gRPC endpoint.

Test Plan

terraform plan for staging contains no changes, for prod removes the resource.

Diff Detail

Repository

rCOMM Comm

Branch

barthap/dev

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 5 2024, 1:26 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2024, 1:26 AM

Harbormaster completed remote builds in B31433: Diff 43891.Sep 5 2024, 1:43 AM

bartek published this revision for review.Sep 5 2024, 2:01 AM

kamil accepted this revision.Sep 5 2024, 5:32 AM

Looks good to me. There shouldn't be any issues with load balancer health checks correct?

This revision is now accepted and ready to land.Sep 5 2024, 7:02 AM

Closed by commit rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet (authored by bartek). · Explain WhySep 9 2024, 6:11 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet.

Revision Contents
Changeset List

Path

Size

services/

terraform/

remote/

service_tunnelbroker.tf

1 line

Diff 43891

View Options

services/terraform/remote/service_tunnelbroker.tf

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines	async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult;		let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult;		const [, canRequestPermission] = permissionPromisesResult;

if (!hasPermission && canRequestPermission) {		if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => {		const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt		// We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears		// doesn't appear immediately but after logged-out modal disappears
await sleep(10);		await sleep(10);
await this.requestAndroidNotificationsPermission();		return await this.requestAndroidNotificationsPermission();
		marcinUnsubmitted Not Done Inline Actions We definitely should return something from this lambda since otherwise it is useless to assign it to variable. When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android. If we find that we don't have permissions then just calling `await this.requestAndroidNotificationsPermission();` would result in a prompt asking for notifications permissions. However if the user grants those permissions then `hasPermissions` is still falsy (since promise returned nothing), so `deviceToken` will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render. This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state. marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})();		})();
hasPermission = permissionResponse;		hasPermission = permissionResponse;
}		}

if (!hasPermission) {		if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);		this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return;		return;
}		}
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines

[terraform] Hide prod Tunnelbroker gRPC endpoint from the InternetClosedPublicActions