Page MenuHomePhabricator
Differential D13245

[terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet
ClosedPublic
Actions

Authored by bartek on Sep 5 2024, 1:26 AM.
Tags
None
Referenced Files
F3366449: D13245.id43891.diff
Mon, Nov 25, 11:28 AM
F3366035: D13245.diff
Mon, Nov 25, 9:13 AM
Unknown Object (File)
Fri, Nov 22, 9:34 AM
Unknown Object (File)
Sun, Nov 10, 12:20 AM
Unknown Object (File)
Sat, Nov 9, 3:02 PM
Unknown Object (File)
Sat, Nov 9, 2:43 PM
Unknown Object (File)
Mon, Nov 4, 12:51 PM
Unknown Object (File)
Mon, Nov 4, 5:13 AM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
kamil
Commits
rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet
Summary

Addresses a part of ENG-9129.

This stops exposing publicly the Tunnelbroker gRPC endpoint.

Test Plan

terraform plan for staging contains no changes, for prod removes the resource.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/dev
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 5 2024, 1:26 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2024, 1:26 AM
Harbormaster completed remote builds in B31433: Diff 43891.Sep 5 2024, 1:43 AM
bartek published this revision for review.Sep 5 2024, 2:01 AM
kamil accepted this revision.Sep 5 2024, 5:32 AM
will accepted this revision.Sep 5 2024, 7:02 AM

Looks good to me. There shouldn't be any issues with load balancer health checks correct?

This revision is now accepted and ready to land.Sep 5 2024, 7:02 AM
Closed by commit rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet (authored by bartek). · Explain WhySep 9 2024, 6:11 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMf13d8767d2bb: [terraform] Hide prod Tunnelbroker gRPC endpoint from the Internet.

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
1 line

Diff 43891

View Options

services/terraform/remote/service_tunnelbroker.tf

Loading...