Enhance DMActivityHandler
ClosedPublic
Actions

Authored by marcin on Sep 12 2024, 5:59 AM.

Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMM7c7da1bc312d: Enhance DMActivityHandler

Summary

This differential addresses Ashoat review for this diff: https://phab.comm.dev/D13246

Test Plan

Create thick thread between users A and B.
Log in as user A on two devices (on web and on native) and log in as user B on third device.
Send message from B to A. Open the thread as A on web. Ensure rescinding happens on native.
Open the thread as A on native. Change opened thread as A on web. Send messages from B to A. Ensure that thread remains read on web.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-9171

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Sep 12 2024, 5:59 AM

Harbormaster completed remote builds in B31560: Diff 44078.Sep 12 2024, 6:16 AM

marcin requested review of this revision.Sep 12 2024, 6:16 AM

The active selector probably could've been factored out as well, and this diff probably could've been split up a bit. But at this point let's just land this work... I've given you enough additional things to worry about as-is

This revision is now accepted and ready to land.Sep 12 2024, 8:25 AM

marcin added a parent revision: D13303: Update input type of useSetThreadUnreadStatus.Sep 12 2024, 8:30 AM

Rebase before landing

This revision was landed with ongoing or failed builds.Sep 12 2024, 10:23 AM

Closed by commit rCOMM7c7da1bc312d: Enhance DMActivityHandler (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM7c7da1bc312d: Enhance DMActivityHandler.

Harbormaster completed remote builds in B31574: Diff 44102.Sep 12 2024, 10:31 AM