Page MenuHomePhabricator
Differential D13310

[native] Launch SIWE backup secret creation
ClosedPublic
Actions

Authored by ashoat on Sep 12 2024, 11:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 9:55 AM
Unknown Object (File)
Wed, Feb 26, 11:37 AM
Unknown Object (File)
Wed, Feb 26, 10:49 AM
Unknown Object (File)
Feb 9 2025, 12:44 PM
Unknown Object (File)
Jan 31 2025, 7:48 PM
Unknown Object (File)
Jan 31 2025, 7:48 PM
Unknown Object (File)
Jan 31 2025, 7:46 PM
Unknown Object (File)
Jan 23 2025, 12:31 AM
View All 46 Files
Subscribers
tomek

Details

Reviewers
marcin
varun
Commits
rCOMM72cc1de5f953: [native] Launch SIWE backup secret creation
Summary

While the backup itself isn't ready, we're ready to generate the secret for SIWE backup. It would be good to get this info from users as part of the new registration flow.

Depends on D13309

Test Plan

Make sure SIWE backup screen shows up in registration flow when using an ETH wallet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
account/
registration/
6 lines
missing-registration-data/
2 lines
2 lines

Diff 44178

View Options

native/account/registration/avatar-selection.react.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines
View Options

native/account/registration/missing-registration-data/missing-registration-data-handler.react.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines
View Options

native/account/registration/registration-types.js

Show First 20 Lines • Show All 367 Lines • ▼ Show 20 Lines) {
return threadMembersWithoutAddedAdmin(threadInfo).length > 2; return threadMembersWithoutAddedAdmin(threadInfo).length > 2;
} }
function threadIsPending(threadID: ?string): boolean { function threadIsPending(threadID: ?string): boolean {
return !!threadID?.startsWith('pending'); return !!threadID?.startsWith('pending');
} }
function threadIsPendingSidebar(threadID: ?string): boolean { function threadIsPendingSidebar(threadID: ?string): boolean {
return !!threadID?.startsWith('pending/sidebar/'); return (
!!threadID?.startsWith('pending/sidebar/') ||
!!threadID?.startsWith('pending/dm_sidebar')
tomekUnsubmitted
Not Done
Inline Actions

Can we extract sidebar and dm_sidebar somewhere as constants?

tomek: Can we extract `sidebar` and `dm_sidebar` somewhere as constants?
);
} }
function getSingleOtherUser( function getSingleOtherUser(
threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo, threadInfo: LegacyRawThreadInfo | RawThreadInfo | ThreadInfo,
viewerID: ?string, viewerID: ?string,
): ?string { ): ?string {
if (!viewerID) { if (!viewerID) {
return undefined; return undefined;
▲ Show 20 Lines • Show All 1,407 Lines • Show Last 20 Lines