Page MenuHomePhabricator
Differential D13374

[lib] refactor methods from `PeerToPeerContext` to utils
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 5:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 9:17 PM
Unknown Object (File)
Tue, Oct 22, 10:41 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Sun, Oct 20, 7:45 PM
Unknown Object (File)
Oct 9 2024, 2:41 PM
Unknown Object (File)
Oct 5 2024, 2:07 AM
View All 36 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
marcin
Commits
rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils
Summary

ENG-9106.

The code in Context is messy and complicated, moving this to methods to make it clean. See usages in next diff - I am going to link source code from Githb to make it easier for review.

Depends on D13373

Test Plan

Tested in D13376

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 18 2024, 5:09 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 5:09 AM
kamil added a child revision: D13376: [lib] refactor sending `OutboundP2PMessages` to peers.Sep 18 2024, 5:15 AM
Harbormaster completed remote builds in B31682: Diff 44292.Sep 18 2024, 5:26 AM
kamil added inline comments.Sep 18 2024, 5:41 AM
lib/utils/peer-to-peer-communication-utils.js
22–61 ↗(On Diff #44292)

code here

63–92 ↗(On Diff #44292)

code here and here

94–134 ↗(On Diff #44292)

code here but most of it is already extracted to functions above

136–182 ↗(On Diff #44292)

code here and here.

kamil published this revision for review.Sep 18 2024, 5:43 AM
kamil edited the test plan for this revision. (Show Details)
tomek accepted this revision.Sep 18 2024, 8:08 AM
tomek added inline comments.
lib/utils/peer-to-peer-communication-utils.js
7–10 ↗(On Diff #44292)

Can be merged

bartek accepted this revision.Sep 18 2024, 10:55 PM
This revision is now accepted and ready to land.Sep 18 2024, 10:55 PM
kamil updated this revision to Diff 44327.Sep 19 2024, 3:27 AM

merge imports

Harbormaster completed remote builds in B31710: Diff 44327.Sep 19 2024, 3:44 AM
Closed by commit rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils (authored by kamil). · Explain WhySep 19 2024, 3:49 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils.

Revision Contents
Changeset List

PathSize
lib/
utils/
183 lines

Diff 44327

View Options

lib/utils/peer-to-peer-communication-utils.js

Loading...