Page MenuHomePhabricator

[lib] refactor methods from `PeerToPeerContext` to utils
ClosedPublic

Authored by kamil on Sep 18 2024, 5:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 10:41 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Sun, Oct 20, 7:45 PM
Unknown Object (File)
Oct 9 2024, 2:41 PM
Unknown Object (File)
Oct 5 2024, 2:07 AM
Unknown Object (File)
Oct 2 2024, 9:59 AM
Subscribers

Details

Summary

ENG-9106.

The code in Context is messy and complicated, moving this to methods to make it clean. See usages in next diff - I am going to link source code from Githb to make it easier for review.

Depends on D13373

Test Plan

Tested in D13376

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
lib/utils/peer-to-peer-communication-utils.js
22–61 ↗(On Diff #44292)

code here

63–92 ↗(On Diff #44292)

code here and here

94–134 ↗(On Diff #44292)

code here but most of it is already extracted to functions above

136–182 ↗(On Diff #44292)

code here and here.

kamil published this revision for review.Sep 18 2024, 5:43 AM
kamil edited the test plan for this revision. (Show Details)
tomek added inline comments.
lib/utils/peer-to-peer-communication-utils.js
7–10 ↗(On Diff #44292)

Can be merged

This revision is now accepted and ready to land.Sep 18 2024, 10:55 PM