Page MenuHomePhabricator
Differential D13373

[lib] refactor notif code to support creating session with multiple devices of one user
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 5:04 AM.
Tags
None
Referenced Files
F3012529: D13373.id44334.diff
Sat, Oct 19, 3:37 AM
F3011534: D13373.id44326.diff
Sat, Oct 19, 1:25 AM
F3011489: D13373.id44291.diff
Sat, Oct 19, 1:23 AM
Unknown Object (File)
Sat, Oct 5, 4:06 PM
Unknown Object (File)
Sat, Oct 5, 1:53 PM
Unknown Object (File)
Thu, Oct 3, 6:52 PM
Unknown Object (File)
Wed, Oct 2, 2:14 AM
Unknown Object (File)
Sun, Sep 29, 4:12 AM
View All 36 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
marcin
Commits
rCOMM829c23c21d48: [lib] refactor notif code to support creating session with multiple devices of…
Summary

ENG-9106.

Updating code to avoid calling Identity multiple times.

Depends on D13372

Test Plan

Tested in D13376

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 18 2024, 5:04 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 5:04 AM
kamil edited the summary of this revision. (Show Details)Sep 18 2024, 5:06 AM
kamil added a parent revision: D13372: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in `PeerOlmSessionCreatorContextType`.
kamil added a child revision: D13374: [lib] refactor methods from `PeerToPeerContext` to utils.Sep 18 2024, 5:09 AM
Harbormaster completed remote builds in B31681: Diff 44291.Sep 18 2024, 5:20 AM
kamil published this revision for review.Sep 18 2024, 5:43 AM
kamil edited the test plan for this revision. (Show Details)
marcin accepted this revision.Sep 18 2024, 7:38 AM
This revision is now accepted and ready to land.Sep 18 2024, 7:38 AM
tomek accepted this revision.Sep 18 2024, 8:03 AM
bartek accepted this revision.Sep 18 2024, 10:53 PM
kamil updated this revision to Diff 44326.Sep 19 2024, 3:26 AM

rebase

Harbormaster completed remote builds in B31709: Diff 44326.Sep 19 2024, 3:47 AM
Closed by commit rCOMM829c23c21d48: [lib] refactor notif code to support creating session with multiple devices of… (authored by kamil). · Explain WhySep 19 2024, 3:49 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM829c23c21d48: [lib] refactor notif code to support creating session with multiple devices of….

Revision Contents
Changeset List

PathSize
lib/
push/
47 lines

Diff 44334

View Options

lib/push/send-utils.js

Loading...