Page MenuHomePhabricator

[lib] Introduce updateRelationshipSpec
Needs ReviewPublic

Authored by ashoat on Thu, Sep 19, 3:47 PM.
Tags
None
Referenced Files
F2770836: D13392.id44350.diff
Thu, Sep 19, 9:41 PM
F2770748: D13392.id44350.diff
Thu, Sep 19, 9:28 PM
F2770727: D13392.id.diff
Thu, Sep 19, 9:27 PM
F2770718: D13392.diff
Thu, Sep 19, 9:26 PM
F2770045: D13392.diff
Thu, Sep 19, 7:25 PM
Subscribers
None

Details

Reviewers
tomek
kamil
will
Summary

This addresses ENG-9329.

Depends on D13391

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

lib/shared/dm-ops/update-relationship-spec.js
103

One thing I'm curious about is whether we should introduce a new queue for FIDs / AuxUserStore

Arguably we've derisked the possibility of a scenario where the message comes in before FarcasterDataHandler has a chance to update the AuxUserStore, since we're relying on findUserIdentities calls instead of AuxUserStore