Page MenuHomePhabricator
Differential D13395

[terraform] Add blob metric filters and alarms
ClosedPublic
Actions

Authored by will on Sep 19 2024, 9:57 PM.
Tags
None
Referenced Files
F3339744: D13395.diff
Thu, Nov 21, 8:36 PM
Unknown Object (File)
Wed, Nov 20, 10:18 AM
Unknown Object (File)
Wed, Nov 20, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 5:36 AM
Unknown Object (File)
Oct 22 2024, 10:40 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 22 2024, 10:21 AM
Unknown Object (File)
Oct 21 2024, 10:01 AM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM4d58d61ff0ee: [terraform] Add blob metric filters and alarms
Summary

This implements the actual cloudwatch alarms filtering on the errorTypes set up prior in the stack

Depends on D13394

Test Plan

Trigger alarms on AWS Staging through a custom docker image

Diff Detail

Repository
rCOMM Comm
Branch
telemetry_blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Sep 19 2024, 9:57 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 19 2024, 9:57 PM
will added inline comments.Sep 19 2024, 9:59 PM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137

Will remove space before landing. Unsure how that got there

services/terraform/remote/main.tf
27

Moved this over to main.tf as it's now shared between identity and blob. Maybe not the best place? Unsure if I should maybe move this the ecs file

Harbormaster completed remote builds in B31723: Diff 44353.Sep 19 2024, 10:13 PM
will requested review of this revision.Sep 19 2024, 10:13 PM
bartek accepted this revision.Sep 20 2024, 4:36 AM
This revision is now accepted and ready to land.Sep 20 2024, 4:36 AM
Closed by commit rCOMM4d58d61ff0ee: [terraform] Add blob metric filters and alarms (authored by will). · Explain WhySep 23 2024, 10:02 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM4d58d61ff0ee: [terraform] Add blob metric filters and alarms.
bartek added inline comments.Sep 23 2024, 11:00 PM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137

And it's been left 🙃

bartek added inline comments.Sep 24 2024, 12:21 AM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137

Fixed it in D13444

bartek mentioned this in D13444: [terraform] Use JSON logs in Blob Cleanup task.Sep 24 2024, 12:21 AM
will added inline comments.Sep 24 2024, 8:28 AM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137

Oops. Thanks for that!

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
49 lines
2 lines
2 lines

Diff 44353

View Options

services/terraform/remote/aws_cloudwatch_alarms.tf

Loading...
View Options

services/terraform/remote/main.tf

Loading...
View Options

services/terraform/remote/service_identity.tf

Loading...