Page MenuHomePhabricator

[terraform] Add blob metric filters and alarms
ClosedPublic

Authored by will on Sep 19 2024, 9:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 5:36 AM
Unknown Object (File)
Tue, Oct 22, 10:40 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Mon, Oct 21, 10:01 AM
Unknown Object (File)
Sun, Oct 20, 7:13 PM
Unknown Object (File)
Tue, Oct 15, 10:54 PM
Unknown Object (File)
Tue, Oct 15, 9:32 PM
Subscribers

Details

Summary

This implements the actual cloudwatch alarms filtering on the errorTypes set up prior in the stack

Depends on D13394

Test Plan

Trigger alarms on AWS Staging through a custom docker image

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

services/terraform/remote/aws_cloudwatch_alarms.tf
136–137 ↗(On Diff #44353)

Will remove space before landing. Unsure how that got there

services/terraform/remote/main.tf
27 ↗(On Diff #44353)

Moved this over to main.tf as it's now shared between identity and blob. Maybe not the best place? Unsure if I should maybe move this the ecs file

will requested review of this revision.Sep 19 2024, 10:13 PM
This revision is now accepted and ready to land.Sep 20 2024, 4:36 AM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137 ↗(On Diff #44353)

And it's been left 🙃

services/terraform/remote/aws_cloudwatch_alarms.tf
136–137 ↗(On Diff #44353)

Fixed it in D13444

services/terraform/remote/aws_cloudwatch_alarms.tf
136–137 ↗(On Diff #44353)

Oops. Thanks for that!