Page MenuHomePhabricator
Differential D13395

[terraform] Add blob metric filters and alarms
AcceptedPublic
Actions

Authored by will on Thu, Sep 19, 9:57 PM.
Tags
None
Referenced Files
F2785009: D13395.id.diff
Fri, Sep 20, 7:08 PM
F2784447: D13395.id.diff
Fri, Sep 20, 6:30 PM
F2771065: D13395.id44353.diff
Thu, Sep 19, 10:14 PM
F2771061: D13395.id.diff
Thu, Sep 19, 10:14 PM
F2771060: D13395.diff
Thu, Sep 19, 10:14 PM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Summary

This implements the actual cloudwatch alarms filtering on the errorTypes set up prior in the stack

Depends on D13394

Test Plan

Trigger alarms on AWS Staging through a custom docker image

Diff Detail

Repository
rCOMM Comm
Branch
telemetry_blob
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Thu, Sep 19, 9:57 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Sep 19, 9:57 PM
will added inline comments.Thu, Sep 19, 9:59 PM
services/terraform/remote/aws_cloudwatch_alarms.tf
136–137

Will remove space before landing. Unsure how that got there

services/terraform/remote/main.tf
27

Moved this over to main.tf as it's now shared between identity and blob. Maybe not the best place? Unsure if I should maybe move this the ecs file

Harbormaster completed remote builds in B31723: Diff 44353.Thu, Sep 19, 10:13 PM
will requested review of this revision.Thu, Sep 19, 10:13 PM
bartek accepted this revision.Fri, Sep 20, 4:36 AM
This revision is now accepted and ready to land.Fri, Sep 20, 4:36 AM

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
49 lines
2 lines
2 lines

Diff 44353

View Options

services/terraform/remote/aws_cloudwatch_alarms.tf

Loading...
View Options

services/terraform/remote/main.tf

Loading...
View Options

services/terraform/remote/service_identity.tf

Loading...