Page MenuHomePhabricator

[lib] Avoid unnecessary sets creation
ClosedPublic

Authored by tomek on Sep 20 2024, 2:09 AM.
Tags
None
Referenced Files
F3299831: D13400.id44358.diff
Sun, Nov 17, 3:49 PM
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Nov 8, 1:42 AM
Unknown Object (File)
Fri, Nov 8, 1:33 AM
Unknown Object (File)
Fri, Oct 25, 2:38 AM
Unknown Object (File)
Sat, Oct 19, 1:54 PM
Unknown Object (File)
Oct 7 2024, 5:48 PM
Unknown Object (File)
Oct 3 2024, 6:33 PM
Subscribers

Details

Summary

We don't need to create sets for the queues - we can as effectively check the object keys. The benefit of the new approach is that we don't perform a linear amount of work when new entities appear.

Test Plan
  1. Created an operation with a reaction that was received before an operation creating the message
  2. Created an operation with an entry edit that was received before an operation creating the entry
  3. Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage