Page MenuHomePhabricator
Differential D13392

[lib] Introduce updateRelationshipSpec
ClosedPublic
Actions

Authored by ashoat on Sep 19 2024, 3:47 PM.
Tags
None
Referenced Files
F3316237: D13392.id44350.diff
Tue, Nov 19, 5:58 PM
Unknown Object (File)
Sun, Nov 17, 9:47 AM
Unknown Object (File)
Fri, Nov 1, 7:23 AM
Unknown Object (File)
Fri, Nov 1, 7:23 AM
Unknown Object (File)
Fri, Nov 1, 7:23 AM
Unknown Object (File)
Fri, Nov 1, 7:18 AM
Unknown Object (File)
Tue, Oct 22, 10:41 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
View All 29 Files
Subscribers
None

Details

Reviewers
tomek
kamil
will
Commits
rCOMMb9bdf51320be: [lib] Introduce updateRelationshipSpec
Summary

This addresses ENG-9329.

Depends on D13391

Test Plan

For now, just Flow. I'll test this at a later point in the stack; for now, putting up diffs following the team's recent pattern to get feedback

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 19 2024, 3:47 PM
ashoat added inline comments.Sep 19 2024, 3:53 PM
lib/shared/dm-ops/update-relationship-spec.js
103 ↗(On Diff #44350)

One thing I'm curious about is whether we should introduce a new queue for FIDs / AuxUserStore

Arguably we've derisked the possibility of a scenario where the message comes in before FarcasterDataHandler has a chance to update the AuxUserStore, since we're relying on findUserIdentities calls instead of AuxUserStore

Harbormaster completed remote builds in B31720: Diff 44350.Sep 19 2024, 4:04 PM
ashoat requested review of this revision.Sep 19 2024, 4:04 PM
kamil accepted this revision.Sep 20 2024, 2:01 AM
kamil added inline comments.
lib/shared/dm-ops/update-relationship-spec.js
103 ↗(On Diff #44350)

I think relying on findUserIdentities should be sufficient

This revision is now accepted and ready to land.Sep 20 2024, 2:01 AM
Closed by commit rCOMMb9bdf51320be: [lib] Introduce updateRelationshipSpec (authored by ashoat). · Explain WhySep 20 2024, 6:16 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMb9bdf51320be: [lib] Introduce updateRelationshipSpec.
ashoat mentioned this in D13433: [lib] Include targetUserID in DMUpdateRelationshipOperation.Sep 23 2024, 10:20 PM
ashoat mentioned this in rCOMM625c27ad811e: [lib] Include targetUserID in DMUpdateRelationshipOperation.Sep 24 2024, 3:04 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
110 lines

Diff 44370

View Options

lib/shared/dm-ops/dm-op-specs.js

Loading...
View Options

lib/shared/dm-ops/update-relationship-spec.js

Loading...