[terraform] Use JSON logs in Blob Cleanup task
ClosedPublic
Actions

Authored by bartek on Sep 24 2024, 12:20 AM.

Details

Reviewers

Commits

rCOMM07fa6f5e9cba: [terraform] Use JSON logs in Blob Cleanup task

Summary

We have separate task definition for blob cleanup. Now, when Blob Service supports JSON logs, we can enable them for this task too

Test Plan

terraform plan. I'll check logs format after this is landed by browsing the /ecs/blob-cleanup log group.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 24 2024, 12:20 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 24 2024, 12:20 AM

bartek published this revision for review.Sep 24 2024, 12:21 AM

bartek mentioned this in D13395: [terraform] Add blob metric filters and alarms.

bartek added inline comments.

services/terraform/remote/aws_cloudwatch_alarms.tf
138	From D13395

Harbormaster completed remote builds in B31811: Diff 44478.Sep 24 2024, 12:41 AM

will accepted this revision.Sep 24 2024, 8:15 AM

This revision is now accepted and ready to land.Sep 24 2024, 8:15 AM

Closed by commit rCOMM07fa6f5e9cba: [terraform] Use JSON logs in Blob Cleanup task (authored by bartek). · Explain WhySep 25 2024, 8:36 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM07fa6f5e9cba: [terraform] Use JSON logs in Blob Cleanup task.

Revision Contents
Changeset List

Path

Size

services/

terraform/

remote/

aws_cloudwatch_alarms.tf

1 line

task_blob_cleanup.tf

4 lines

Diff 44478

View Options

services/terraform/remote/aws_cloudwatch_alarms.tf