Details
Details
- Reviewers
marcin - Commits
- rCOMMe11444b5ba9d: [native] Avoid Promise.allSettled
Confirmed that notifs sent from Android for a new session worked
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/push/send-utils.js | ||
|---|---|---|
| 996–1014 ↗ | (On Diff #44454) | Can we add it to our utils /Users/palys/code/comm/lib/utils/promises.js? |
| lib/push/send-utils.js | ||
|---|---|---|
| 996–1014 ↗ | (On Diff #44454) | We could, but then we would have to maintain the types. I looked into this, and I'm a bit concerned because the types we'd need for our current version of Flow don't match the types in their main branch. This implies that we'd have to update it at some point... I'm not sure it's worth the effort |