Page MenuHomePhabricator

[lib][native] fix farcaster outline icon and update CommIcons.ttf
ClosedPublic

Authored by varun on Sep 25 2024, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 3:56 AM
Unknown Object (File)
Sat, Nov 9, 2:23 AM
Unknown Object (File)
Sat, Nov 2, 8:33 PM
Unknown Object (File)
Thu, Oct 31, 2:14 AM
Unknown Object (File)
Thu, Oct 31, 2:13 AM
Unknown Object (File)
Thu, Oct 31, 1:59 AM
Unknown Object (File)
Mon, Oct 21, 9:49 AM
Subscribers

Details

Summary

icon was off center and as a result looked a little strange on web. it also wasn't an outline like the other icons in the list. lastly, i forgot to include the updated CommIcons.ttf file, which we need to make the icon available on native

this diff re-centers the icon, makes it an outline, and updates CommIcons.ttf

Test Plan

icon looks correct now. CommIcons.ttf update is tested in next diff which actually uses it to display farcaster icon on native (android)

also tested that some of the existing CommIcon icons (e.g. "cloud-filled") still look right on native

Screenshot 2024-09-25 at 7.14.22 PM.png (966×828 px, 101 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun held this revision as a draft.
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
varun published this revision for review.Sep 25 2024, 5:21 PM

will wait for CI to pass before landing

This revision is now accepted and ready to land.Sep 25 2024, 5:24 PM