[identity] improve error log for failed backup deletion
ClosedPublic
Actions

Authored by varun on Sep 26 2024, 9:44 PM.

Details

Reviewers

bartek
will

Commits

rCOMM5832c66e4bfa: [identity] improve error log for failed backup deletion

Summary

We've noticed that sometimes the response body is empty. Improving this error log to hopefully uncover some more information if we see another backup deletion call fail with no response body

Depends on D13498

Test Plan

disabled local backup service and confirmed that the HTTP response code appears in log

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Sep 26 2024, 9:44 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 26 2024, 9:44 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 26 2024, 9:49 PM

Harbormaster failed remote builds in B31893: Diff 44617!

Harbormaster completed remote builds in B31893: Diff 44617.Sep 26 2024, 10:59 PM

varun requested review of this revision.Sep 26 2024, 10:59 PM

bartek accepted this revision.Sep 26 2024, 11:02 PM

This revision is now accepted and ready to land.Sep 26 2024, 11:02 PM

Closed by commit rCOMM5832c66e4bfa: [identity] improve error log for failed backup deletion (authored by varun). · Explain WhySep 27 2024, 8:08 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5832c66e4bfa: [identity] improve error log for failed backup deletion.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

backup.rs

11 lines

Diff 44617

View Options

services/identity/src/backup.rs

[identity] improve error log for failed backup deletionClosedPublicActions