[blob] Don't log request payload in tracing span
ClosedPublic
Actions

Authored by bartek on Sep 30 2024, 4:34 AM.

Tags

None

Referenced Files

	F3343576: D13516.id44752.diff
	Fri, Nov 22, 3:20 AM

	F3340859: D13516.diff
	Thu, Nov 21, 10:12 PM

	Unknown Object (File)
	Fri, Nov 1, 4:46 PM

	Unknown Object (File)
	Fri, Nov 1, 4:46 PM

	Unknown Object (File)
	Fri, Nov 1, 4:45 PM

	Unknown Object (File)
	Fri, Nov 1, 4:22 PM

	Unknown Object (File)
	Fri, Nov 1, 5:37 AM

	Unknown Object (File)
	Thu, Oct 31, 6:42 AM

View All 38 Files

Subscribers

ashoat

tomek

Details

Reviewers

will
varun
kamil

Commits

rCOMMc9f0d1d0a045: [blob] Don't log request payload in tracing span

Summary

Noticed that there's some spam in blob logs because the instrument includes full request payload in logs

Test Plan

Ran local Blob Service, called the endpoint. The payload is no longer printed.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 30 2024, 4:34 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 30 2024, 4:34 AM

Harbormaster completed remote builds in B31924: Diff 44669.Sep 30 2024, 5:06 AM

bartek published this revision for review.Sep 30 2024, 5:54 AM

kamil accepted this revision.Sep 30 2024, 6:35 AM

This revision is now accepted and ready to land.Sep 30 2024, 6:35 AM

Closed by commit rCOMMc9f0d1d0a045: [blob] Don't log request payload in tracing span (authored by bartek). · Explain WhyOct 1 2024, 6:44 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc9f0d1d0a045: [blob] Don't log request payload in tracing span.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

http/

handlers/

holders.rs

2 lines

Diff 44669

View Options

services/blob/src/http/handlers/holders.rs

[blob] Don't log request payload in tracing spanClosedPublicActions