[web] Move declarations closer to where they're used in ComposedMessage
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:22 PM.

Tags

None

Referenced Files

	F3364976: D13674.diff
	Mon, Nov 25, 6:04 AM

	Unknown Object (File)
	Fri, Nov 22, 1:54 PM

	Unknown Object (File)
	Sun, Nov 10, 7:51 PM

	Unknown Object (File)
	Sun, Nov 10, 7:33 PM

	Unknown Object (File)
	Sun, Nov 10, 6:11 PM

	Unknown Object (File)
	Sun, Nov 10, 7:04 AM

	Unknown Object (File)
	Wed, Nov 6, 12:43 AM

	Unknown Object (File)
	Mon, Nov 4, 9:20 AM

View All 31 Files

Subscribers

None

Details

Reviewers

tomek

Commits

rCOMMf367427d3b5c: [web] Move declarations closer to where they're used in ComposedMessage

Summary

Now that we no longer have a separate function and class component, we can localize some of these declarations.

Depends on D13673

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:22 PM

ashoat added a child revision: D13675: [lib][web] Narrow ChatMessageInfoItem to ComposableChatMessageInfoItem where appropriate.

Harbormaster completed remote builds in B32158: Diff 45033.Oct 9 2024, 8:53 PM

ashoat requested review of this revision.Oct 9 2024, 8:53 PM

tomek accepted this revision.Oct 10 2024, 8:25 AM

This revision is now accepted and ready to land.Oct 10 2024, 8:25 AM

Closed by commit rCOMMf367427d3b5c: [web] Move declarations closer to where they're used in ComposedMessage (authored by ashoat). · Explain WhyOct 13 2024, 6:43 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf367427d3b5c: [web] Move declarations closer to where they're used in ComposedMessage.

Revision Contents
Changeset List

Path

Size

web/

chat/

composed-message.react.js

116 lines

Diff 45033

View Options

web/chat/composed-message.react.js

[web] Move declarations closer to where they're used in ComposedMessageClosedPublicActions