Page MenuHomePhabricator
Differential D13687

[lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
ClosedPublic
Actions

Authored by ashoat on Oct 9 2024, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 11:31 PM
Unknown Object (File)
Nov 22 2024, 8:24 AM
Unknown Object (File)
Nov 22 2024, 7:51 AM
Unknown Object (File)
Nov 22 2024, 2:45 AM
Unknown Object (File)
Nov 20 2024, 9:34 AM
Unknown Object (File)
Nov 10 2024, 5:32 PM
Unknown Object (File)
Nov 10 2024, 1:53 PM
Unknown Object (File)
Nov 10 2024, 5:00 AM
View All 56 Files
Subscribers
None

Details

Reviewers
tomek
Commits
rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem
Summary

This function will allow us to merge RobotextMessageInfos into preceding (older) RobotextChatMessageInfoItems.

The merging is implemented on the spec of the newer RobotextChatMessageInfoItem.

Depends on D13686

Test Plan

Tested in combination with the following diffs, where I construct RobotextChatMessageInfoItem with an array of messageInfos to represent combined messages (ENG-9559

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Oct 9 2024, 8:33 PM
ashoat added a child revision: D13688: [lib] Explain auto-created Farcaster mutual friend threads better.
Harbormaster completed remote builds in B32171: Diff 45046.Oct 9 2024, 10:08 PM
ashoat requested review of this revision.Oct 9 2024, 10:08 PM
ashoat updated this revision to Diff 45065.Oct 10 2024, 11:01 AM

Don't merge messages that have reactions or a sidebar

lib/selectors/chat-selectors.js
521–522

These checks are superfluous, since only composable messages can be edited or pinned currently

But I figured it wouldn't hurt to check

Harbormaster completed remote builds in B32182: Diff 45065.Oct 10 2024, 11:19 AM
tomek accepted this revision.Oct 11 2024, 7:45 AM
This revision is now accepted and ready to land.Oct 11 2024, 7:45 AM
ashoat mentioned this in D13686: [lib][native][web] Add support for rendering array of messages in RobotextChatMessageInfoItem.Oct 13 2024, 5:07 PM
Closed by commit rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem (authored by ashoat). · Explain WhyOct 13 2024, 6:44 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf0679dd4de0d: [lib] Introduce MessageSpec.mergeIntoPrecedingRobotextMessageItem.

Revision Contents
Changeset List

PathSize
lib/
selectors/
41 lines
shared/
messages/
10 lines

Diff 45065

View Options

lib/selectors/chat-selectors.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...