Page MenuHomePhabricator
Differential D13655

[lib] Add types for Blob Service requests and responses
ClosedPublic
Actions

Authored by bartek on Oct 9 2024, 2:13 AM.
Tags
None
Referenced Files
F3520966: D13655.id45005.diff
Mon, Dec 23, 1:53 AM
F3520503: D13655.id45088.diff
Mon, Dec 23, 12:34 AM
F3518537: D13655.id45067.diff
Sun, Dec 22, 8:14 PM
Unknown Object (File)
Thu, Dec 19, 11:35 AM
Unknown Object (File)
Thu, Dec 19, 11:34 AM
Unknown Object (File)
Thu, Dec 19, 11:34 AM
Unknown Object (File)
Fri, Nov 29, 7:07 AM
Unknown Object (File)
Fri, Nov 29, 5:03 AM
View All 95 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM11b6ebffce87: [lib] Add types for Blob Service requests and responses
Summary

Added types and validators for Blob service batch-holder endpoints.
They directly correspond to Rust structs from D13617.

Depends on D13654

Test Plan

flow. Their usage is tested in the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Oct 9 2024, 2:13 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptOct 9 2024, 2:13 AM
bartek added a child revision: D13656: [lib] Use response validators in multiple-holder calls.Oct 9 2024, 2:16 AM
Harbormaster completed remote builds in B32135: Diff 45005.Oct 9 2024, 2:33 AM
bartek published this revision for review.Oct 9 2024, 3:01 AM
kamil accepted this revision.Oct 10 2024, 2:47 AM
  1. I don't think we need validators for requests, those won't be used
  2. Can you reference the Rust file here, and This file in Rust codebase? Similar to code here.
lib/types/blob-service-types.js
7–10 ↗(On Diff #45005)

there are couple places in codebase where we can use this type now

43 ↗(On Diff #45005)

I think we should match Rust

This revision is now accepted and ready to land.Oct 10 2024, 2:47 AM
kamil added inline comments.Oct 10 2024, 2:49 AM
lib/types/blob-service-types.js
7–10 ↗(On Diff #45005)

looks like it's done in D13656.
Thinking of deduplicating BlobHashAndHolder type too,

bartek added a comment.Oct 10 2024, 6:24 AM
In D13655#382843, @kamil wrote:
  1. I don't think we need validators for requests, those won't be used

Okay so I'll remove them

  1. Can you reference the Rust file here, and This file in Rust codebase? Similar to code here.

Good idea, I'll do that!

lib/types/blob-service-types.js
7–10 ↗(On Diff #45005)

Thinking of deduplicating BlobHashAndHolder type too,

Yeah, if not done now, it's tracked in ENG-9422

bartek updated this revision to Diff 45067.Oct 10 2024, 11:03 AM

Address feedback: Rename types, remove request validators, add comments

Harbormaster failed remote builds in B32184: Diff 45067!Oct 10 2024, 11:09 AM
bartek updated this revision to Diff 45069.Oct 10 2024, 11:22 AM

Rebase

Harbormaster failed remote builds in B32186: Diff 45069!Oct 10 2024, 11:48 AM
bartek updated this revision to Diff 45073.Oct 10 2024, 11:54 AM

Rebase

Harbormaster completed remote builds in B32190: Diff 45073.Oct 10 2024, 12:12 PM
Closed by commit rCOMM11b6ebffce87: [lib] Add types for Blob Service requests and responses (authored by bartek). · Explain WhyOct 10 2024, 2:06 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM11b6ebffce87: [lib] Add types for Blob Service requests and responses.

Revision Contents
Changeset List

PathSize
lib/
facts/
4 lines
types/
78 lines
shared/
comm-lib/
src/
blob/
7 lines

Diff 45088

View Options

lib/facts/blob-service.js

Loading...
View Options

lib/types/blob-service-types.js

Loading...
View Options

shared/comm-lib/src/blob/types.rs

Loading...