This reduces a bunch of noise in community roots when people get auto-added to the communities.
Depends on D13688
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/plural_join_thread
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Note that the extra vertical spacing in the test video is caused by ENG-2928, and is unrelated to the work here
| lib/shared/messages/join-thread-message-spec.js | ||
|---|---|---|
| 158–170 ↗ | (On Diff #45048) | All but one generated robotext messages will be discarded while merging the messages, which means that we're performing O(n^2) operations where n is a number of consecutive join thread messages. This isn't a big issue unless we expect a huge number of thread joins. |
| lib/shared/messages/remove-members-message-spec.js | ||
| 39 ↗ | (On Diff #45048) | |
| lib/shared/messages/join-thread-message-spec.js | ||
|---|---|---|
| 158–170 ↗ | (On Diff #45048) | Makes sense. I don't think it should be a big concern, and I didn't notice any performance issues while testing |