Paths

Table of Contentst

Differential D13662

[lib] extract code responsible for confirming P2P message to a hook
ClosedPublic
Actions

Authored by kamil on Oct 9 2024, 7:33 AM.

Details

Reviewers

tomek

Commits

rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook

Summary

Part of ENG-9456.

I need to reuse this code in next diff.

Test Plan

Tested in next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Oct 9 2024, 7:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptOct 9 2024, 7:33 AM

kamil added a child revision: D13663: [lib] send confirmation for ignored DM ops.Oct 9 2024, 7:41 AM

kamil published this revision for review.Oct 9 2024, 7:51 AM

Harbormaster completed remote builds in B32144: Diff 45016.Oct 9 2024, 7:52 AM

tomek accepted this revision.Oct 10 2024, 5:28 AM

tomek added inline comments.

lib/handlers/db-ops-handler.react.js
46 ↗	(On Diff #45016)	Shouldn't we await to keep it consistent with the previous implementation?

This revision is now accepted and ready to land.Oct 10 2024, 5:28 AM

add await

Harbormaster completed remote builds in B32222: Diff 45139.Oct 14 2024, 3:46 AM

Closed by commit rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook (authored by kamil). · Explain WhyOct 14 2024, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0ea97c431b17: [lib] extract code responsible for confirming P2P message to a hook.

Revision Contents
Changeset List

Path

Size

lib/

handlers/

db-ops-handler.react.js

39 lines

tunnelbroker/

use-confirm-peer-to-peer-message.js

57 lines

Diff 45145

View Options

lib/handlers/db-ops-handler.react.js