In next diff, I will introduce a handler component responsible for navigating to this modal if a user does not have an associated farcaster account (logic will be further refined later in stack to not display if existing user has just declined to connect a farcaster account and to display if farcaster user is only in 3 or fewer communities)
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/components/community-joiner-modal.react.js | ||
|---|---|---|
| 31 ↗ | (On Diff #44610) | Never use colors directly like this |
Comment Actions
fixing the avatars here is tracked in https://linear.app/comm/issue/ENG-9834/get-farcaster-thread-avatars-to-render-correctly-in-new-modals
| native/components/community-joiner-modal.react.js | ||
|---|---|---|
| 66 | this alert will be replaced in a later diff with a new modal from which the user can join the selected community | |
Comment Actions
Please update the test plan to reflect your recent changes. Would be good to see a video of the whole experience
| native/components/community-joiner-modal.react.js | ||
|---|---|---|
| 52 ↗ | (On Diff #45572) | What's the point of using a Set here? We're storing a list of objects, and given object comparison is by reference in JS, I don't think the Set will have any value as opposed to just an array |
| 56 ↗ | (On Diff #45572) | Hmm... wondering if we really need to redo this call whenever the deps change. I'm worried that in production, something will change (eg. the keyserver socket will reconnect) and it will cause the UI to jump while the results are repopulated. Can you check if the UI currently jumps when we call setCommunities a second time here? |