Differential D13864

[lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers
ClosedPublic
Actions

Authored by angelika on Mon, Nov 4, 12:46 PM.

Tags

None

Referenced Files

	F3336522: D13864.id45646.diff
	Thu, Nov 21, 2:41 PM

	F3336337: D13864.id45588.diff
	Thu, Nov 21, 2:24 PM

	F3336251: D13864.id45648.diff
	Thu, Nov 21, 2:12 PM

	F3336016: D13864.id45600.diff
	Thu, Nov 21, 1:41 PM

	Unknown Object (File)
	Mon, Nov 18, 2:33 PM

	Unknown Object (File)
	Sun, Nov 17, 4:42 PM

	Unknown Object (File)
	Sat, Nov 16, 4:00 AM

	Unknown Object (File)
	Sat, Nov 16, 12:39 AM

View All 37 Files

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMM3f50d089ad51: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers

Summary

https://linear.app/comm/issue/ENG-9730/native-crashes-when-call-to-identity-fails

Depends on D13863

Test Plan

Force the error when sending message: 

Create DM with some user
Change identity address to some random address
Remove device lists by dispatching an action as described in the issue
Try to send a message
Verify that the app doesn't crash and user can retry sending the message and you can see the error nicely in the logs

Diff Detail

Repository

Branch

graszka22/ENG-9730

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

angelika created this revision.Mon, Nov 4, 12:46 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Nov 4, 12:46 PM

Harbormaster completed remote builds in B32522: Diff 45588.Mon, Nov 4, 1:06 PM

angelika requested review of this revision.Mon, Nov 4, 1:06 PM

kamil accepted this revision.Tue, Nov 5, 1:41 AM

This revision is now accepted and ready to land.Tue, Nov 5, 1:41 AM

Rebase

Harbormaster completed remote builds in B32532: Diff 45600.Tue, Nov 5, 4:09 AM

Rebase

Harbormaster completed remote builds in B32563: Diff 45646.Wed, Nov 6, 6:07 AM

Closed by commit rCOMM3f50d089ad51: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers (authored by angelika). · Explain WhyWed, Nov 6, 6:41 AM

This revision was automatically updated to reflect the committed changes.

angelika added a commit: rCOMM3f50d089ad51: [lib] Don't swallow errors in useGetAndUpdateDeviceListsForUsers.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

peer-list-hooks.js

14 lines

Diff 45588

lib/hooks/peer-list-hooks.js

Loading...